-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDN algorithm #16
base: main
Are you sure you want to change the base?
Conversation
@2er0 can you take it from here?
|
@CodeLionX please test - I found some time to make the first full working draft.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a brief look and can execute the algorithm locally. 👍🏼
However, I found some issues in the current draft:
- See inline comments (changes to base image)
- The input handling is too tight: You assume that the feature columns are labeled
value*
, but many datasets use other feature names. - All other algorithms store a single model-file. TimeEval currently does not support multiple files. I would suggest that you create an archive when storing the model. You can take a look at Torsk as an example for that.
- Do you perform train-test-splitting within the code? The anomaly score files are very short … TimeEval requires that the scoring has the same length as the input TS. You could use a postprocessing step to perform this transformation (allows you to use Code from TimeEval).
numpy>=1.20.0 | ||
pandas>=1.2.1 | ||
matplotlib>=3.3.4 | ||
scipy>=1.6.0 | ||
scikit-learn>=0.24.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We deliberately pinned the dependencies to ensure reproducibility!
If the new algorithm actually needs a new Python version and different dependencies, we should create a new base image. Otherwise, we have to check if all the other algorithms still work with the new base image.
# -e LOCAL_UID=<current user id> \ | ||
# -e LOCAL_GID=<current groupid> \ | ||
registry.gitlab.hpi.de/akita/i/<your_algorithm>:latest execute-algorithm '{ | ||
registry.gitlab.hpi.de/akita/i/gdn:0.2.6 execute-algorithm '{ | ||
"executionType": "train", | ||
"dataInput": "/data/dataset.csv", | ||
"dataInput": "/data/multi-dataset.csv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert those changes to the README. They only apply to your algorithm and not to the others.
@@ -0,0 +1,18 @@ | |||
FROM registry.gitlab.hpi.de/akita/i/python3-torch:0.2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no version 0.2.6
of the base images yet.
# fixing six.py dataloader issue | ||
COPY GDN/dataloader_fix.py /usr/local/lib/python3.10/site-packages/torch_geometric/data/dataloader.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to the bug report/issue? This looks like a dirty hack.
Adds the GDN algorithm from https://github.com/d-ailin/GDN (Paper: https://doi.org/10.1609/aaai.v35i5.16523)
Fixes #15