Android 13 notification action buttons #10567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Stypox
added a commit
to Stypox/NewPipe
that referenced
this pull request
Nov 16, 2023
Use a workaround initially suggested in TeamNewPipe#10567 Basically tell the system that we're not able to handle "prev" and "next", in order to have 4 customizable action slots instead of just 2 On Android 13+ normal notification actions are useless, so they are not set into the notification builder anymore, to save battery The opposite happens on Android 12-, where media session actions are not set because they don't seem to do anything
5 tasks
|
Thank you very much for trying out this workaround! I improved the code and opened another PR which supersedes this one, see #10580. Could you take a look at that to make sure I didn't miss anything? :-) |
|
@Stypox Looks good to me! Thanks. |
Stypox
added a commit
to Stypox/NewPipe
that referenced
this pull request
Dec 23, 2023
Use a workaround initially suggested in TeamNewPipe#10567 Basically tell the system that we're not able to handle "prev" and "next", in order to have 4 customizable action slots instead of just 2 On Android 13+ normal notification actions are useless, so they are not set into the notification builder anymore, to save battery The opposite happens on Android 12-, where media session actions are not set because they don't seem to do anything
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence
I don't really do much java, used a one-element array as a hacky way of getting an out parameter. The two other questionable things that come to mind are making sessionConnector public and maybe the ternary operator usage in getSupportedQueueNavigatorActions.
I have not tested this on android <13 since I don't have on on hand at the moment.