-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some AndroidX libraries and compileSdk to 34 #10086
Conversation
app/src/main/java/us/shandian/giga/service/DownloadManagerService.java
Outdated
Show resolved
Hide resolved
47c9105
to
e469ee9
Compare
14ade0b
to
a1f20d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to onScroll's documentation the initialEvent
might be null
in case of error, so it's better to just return false
(thus ignoring all future events) from onScroll
in that case, instead of crashing. I already changed the code, replacing !!
with if (==null) return false
. Thank you!
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
|
Thanks for noticing, fixed in 9220e32 |
What is it?
Description of the changes in your PR
compileSdk
to 34BundleCompat
andIntentCompat
to fix some deprecationsAPK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence