Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some AndroidX libraries and compileSdk to 34 #10086

Merged
merged 5 commits into from
Dec 23, 2023

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented May 11, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update AppCompat 1.5.1 -> 1.6.1 (changelog)
  • Update Core 1.10.0 -> 1.12.0 (changelog)
  • Update Fragment 1.4.1 -> 1.6.1 (changelog)
  • Update Lifecycle 2.5.1 -> 2.6.2 (changelog)
  • Update Preference 1.2.0 -> 1.2.1 (changelog)
  • Update RecyclerView 1.2.1 -> 1.3.2 (changelog)
  • Update ViewPager2 1.1.0-beta1 -> 1.1.0-beta2 (changelog)
  • Update WorkManager 2.7.1 -> 2.8.1 (changelog)
  • Update compileSdk to 34
  • Use new compatibility methods in BundleCompat and IntentCompat to fix some deprecations

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label May 12, 2023
@Isira-Seneviratne Isira-Seneviratne force-pushed the bumpAndroidX branch 3 times, most recently from 47c9105 to e469ee9 Compare June 2, 2023 01:56
@TobiGr TobiGr added the dependency Issues and PRs related to dependencies label Jul 16, 2023
@AudricV AudricV changed the title Update some AndroidX libraries Update some AndroidX libraries and compileSdk to 34 Sep 21, 2023
@TacoTheDank TacoTheDank force-pushed the bumpAndroidX branch 2 times, most recently from 14ade0b to a1f20d9 Compare October 31, 2023 20:39
@Stypox Stypox mentioned this pull request Nov 16, 2023
21 tasks
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to onScroll's documentation the initialEvent might be null in case of error, so it's better to just return false (thus ignoring all future events) from onScroll in that case, instead of crashing. I already changed the code, replacing !! with if (==null) return false. Thank you!

Copy link

sonarcloud bot commented Dec 23, 2023

@Stypox Stypox merged commit ee3455e into TeamNewPipe:dev Dec 23, 2023
4 of 8 checks passed
@TobiGr
Copy link
Member

TobiGr commented Dec 23, 2023

⚠️ Caution, tests fail for the latest commit (and the merge commit as well):

org.schabi.newpipe.database.FeedDAOTest > testUnlinkStreamsOlderThan_KeepMultiple[test(AVD) - 5.0.2] FAILED 
	java.lang.NoSuchMethodError: No interface method toList()Ljava/util/List; in class Lj$/util/stream/Stream; or its super classes (declaration of 'j$.util.stream.Stream' appears in /data/app/org.schabi.newpipe.debug.HEAD-1/base.apk:classes18.dex)
	at org.schabi.newpipe.database.FeedDAOTest.assertEqual(FeedDAOTest.kt:88)

org.schabi.newpipe.database.FeedDAOTest > testUnlinkStreamsOlderThan_KeepOne[test(AVD) - 5.0.2] FAILED 
	java.lang.NoSuchMethodError: No interface method toList()Ljava/util/List; in class Lj$/util/stream/Stream; or its super classes (declaration of 'j$.util.stream.Stream' appears in /data/app/org.schabi.newpipe.debug.HEAD-1/base.apk:classes18.dex)
	at org.schabi.newpipe.database.FeedDAOTest.assertEqual(FeedDAOTest.kt:88)
Tests on test(AVD) - 5.0.2 failed: There was 2 failure(s).

@TeamNewPipe TeamNewPipe deleted a comment from sonarcloud bot Dec 23, 2023
@TeamNewPipe TeamNewPipe deleted a comment from sonarcloud bot Dec 23, 2023
@TeamNewPipe TeamNewPipe deleted a comment from sonarcloud bot Dec 23, 2023
@TeamNewPipe TeamNewPipe deleted a comment from sonarcloud bot Dec 23, 2023
@Stypox
Copy link
Member

Stypox commented Dec 29, 2023

Thanks for noticing, fixed in 9220e32

@TacoTheDank TacoTheDank deleted the bumpAndroidX branch January 17, 2024 22:15
@Stypox Stypox mentioned this pull request Apr 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality dependency Issues and PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants