-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.27.0 (please TEST!) #10930
Comments
player notification buttons don't work. android 12. |
I display comments under the video under whichn there are 26,000 NP displayed only about 1,000 of them. |
org.schabi.newpipe.extractor.stream.Description.getType attemps to do something on a null value which causes the app to crash. Happens unreliably when either focusing the app or attempting to play any YouTube video. |
Android 13 too, though it's specifically the two custom buttons that don't work. The 3 default ones do. |
That's this execption, I guess: caught on a nightly though. Not sure if it is one with the latest extractor commit. Exception
Crash log
|
It's fixed on the extractor dev, but again the comments fix branch which the RC was based on is some commits behind dev |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I can only view one page of comments now. This was not the case in 0.26.1 |
If that's for YouTube, that's a mistake from my side that I fixed in the extractor code. See TeamNewPipe/NewPipeExtractor#1163 (comment). |
This comment was marked as off-topic.
This comment was marked as off-topic.
Raising awareness for #10746, please take a look at it for this release if possible. I know it's possible to add NewPipe's own repo as a workaround, but that's some additional friction for less tech savvy users and it's just more convenient if it's available in the default repo. As of writing, the latest version available on f-droid's default repo is |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
RC2 landed:
Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC2_release.zip |
It looks like more comments are already loaded in RC2, whether all of them I don't know yet. Thanks for launching the functionality I am still very much missing the record of comments to the file. For now, I am assisting in other ways. |
Exception
Crash log
|
@Stypox Notif buttons work now! Still, it would be good to confirm with someone using A12-. |
@JohhanSam that's not a regression (i.e. it was there even in 0.26.1, see #10863). Anyway, could you test #10957?
@fenopa could you provide more information on the crash you are experiencing, and open an issue for it? Since nightly 97 was the same as release 0.26.0, this is also not a regression though.
@NaN-Sz I can reproduce with RC1, but now I can't with RC2. Can you confirm that this is the case? I think Android Studio messed up the package name in |
Rotating your device outside of the app when the comment replies view was the last view shown makes the app crash. Here is a video which shows the problem: Comments.replies.0.27.0.RC2.crash.mp4Stacktrace captured with Scoop
Device: Google Pixel 7a running Android 14 QPR stock ROM (The |
Yes, buttons are working perfectly now. |
Timestamps in comment replies are not clickable https://www.youtube.com/watch?v=GKh2LdXNU3g @armelolsens2496 It’s clickable in comment views, but if you click on replies it isn’t anymore. I'm not sure how actual comment replies behave (i.e. replies to a comment, what i said is reply to video but in comment replies view), I couldn’t find one |
im import my preferences/config, I passed all my configuration without any problem |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@B0pol your issue is actually already fixed after the latest merged changes in TeamNewPipe/NewPipeExtractor#1163, we'll publish a new RC soon |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Android 11, Lineageos 18.1, Lenovo P2 |
Android 10, /e/ OS 18.1, Xiaomi Redmi Note 8T |
Android 14, LineageOS 21, Pixel 4a 5G (bramble) |
New RC, includes small YouTube bugfixes from TeamNewPipe/NewPipeExtractor#1168 Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC4_release.zip |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
0.27.0_RC crashes trying to download with SAF turned off in settings. When SAF is on, everything is fine, but the download path in settings looks weird, like content://com.android.externalstorage.documents/tree/primary:Download. Instead of /storage/emulated/0/Download, when SAF is off, but crashes. Exception
Crash log
|
Fixes comments on videos not loading and videos suddenly not working since a short bit ago or so on my end. |
Have tested on a few different FireStick 4k and 4k Max units and have had no issues at all, great work. |
Testing for regressions
Debug APK (built by our CI in #10929): NewPipe_v0.27.0_RC4_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC4_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases
TODO
[YouTube] Support shows and page header on user channels NewPipeExtractor#1170for 0.27.1NewPipeExtractor version
This version of NewPipe will ship with NewPipeExtractor version 0.24.0.
App changelog
New
Improved
Fixed
Localization and Documentation
Development
compileSdk
to 34 Update some AndroidX libraries and compileSdk to 34 #10086TextLinkifier.java
#10889Extractor changelog
Due to the removal of the usage of InnerTube API keys, some methods in
YoutubeParsingHelper
which can be used by clients have been changed in TeamNewPipe/NewPipeExtractor#1168:areHardcodedClientVersionAndKeyValid
was renamed toisHardcodedClientVersionValid
getKey
was removed, since there is no InnerTube API key anymoreresetClientVersionAndKey
was renamed toresetClientVersion
isHardcodedYoutubeMusicKeyValid
was renamed toisHardcodedYoutubeMusicClientVersionValid
getYoutubeMusicKey
was renamed togetYoutubeMusicClientVersion
and now just returns the version instead of (key, name, version), since there is no key anymore and the name is fixed ("67") and therefore hardcodedNew
Improved
getCommentText
return@Nonnull
values Make getCommentText @Nonnull NewPipeExtractor#1162Fixed
Development
The text was updated successfully, but these errors were encountered: