Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.27.0 (please TEST!) #10930

Closed
7 of 8 tasks
Stypox opened this issue Apr 1, 2024 · 53 comments
Closed
7 of 8 tasks

Release v0.27.0 (please TEST!) #10930

Stypox opened this issue Apr 1, 2024 · 53 comments

Comments

@Stypox
Copy link
Member

Stypox commented Apr 1, 2024

Testing for regressions

Debug APK (built by our CI in #10929): NewPipe_v0.27.0_RC4_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC4_release.zip

Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases

TODO

NewPipeExtractor version

This version of NewPipe will ship with NewPipeExtractor version 0.24.0.

App changelog

New

Improved

Fixed

Localization and Documentation

Development

Extractor changelog

⚠️ This version contains breaking changes (thus the bump to 0.24):

Due to the removal of the usage of InnerTube API keys, some methods in YoutubeParsingHelper which can be used by clients have been changed in TeamNewPipe/NewPipeExtractor#1168:

  • areHardcodedClientVersionAndKeyValid was renamed to isHardcodedClientVersionValid
  • getKey was removed, since there is no InnerTube API key anymore
  • resetClientVersionAndKey was renamed to resetClientVersion
  • isHardcodedYoutubeMusicKeyValid was renamed to isHardcodedYoutubeMusicClientVersionValid
  • getYoutubeMusicKey was renamed to getYoutubeMusicClientVersion and now just returns the version instead of (key, name, version), since there is no key anymore and the name is fixed ("67") and therefore hardcoded
  • other related methods which are not really meant to be used outside of the extractor

New

Improved

Fixed

Development

@Stypox Stypox pinned this issue Apr 1, 2024
@NaN-Sz
Copy link

NaN-Sz commented Apr 1, 2024

player notification buttons don't work. android 12.

@NewNewPipe
Copy link

I display comments under the video under whichn there are 26,000 NP displayed only about 1,000 of them.

@lofcz
Copy link

lofcz commented Apr 3, 2024

org.schabi.newpipe.extractor.stream.Description.getType attemps to do something on a null value which causes the app to crash. Happens unreliably when either focusing the app or attempting to play any YouTube video.

@opusforlife2
Copy link
Collaborator

player notification buttons don't work. android 12.

Android 13 too, though it's specifically the two custom buttons that don't work. The 3 default ones do.

@TobiGr
Copy link
Member

TobiGr commented Apr 3, 2024

org.schabi.newpipe.extractor.stream.Description.getType attemps to do something on a null value which causes the app to crash. Happens unreliably when either focusing the app or attempting to play any YouTube video.

That's this execption, I guess: caught on a nightly though. Not sure if it is one with the latest extractor commit.

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Language: de-
  • Service: none
  • Version: 0.26.1
  • OS: Linux Android 13 - 33
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.extractor.stream.Description.getType()' on a null object reference
	at org.schabi.newpipe.util.text.TextLinkifier.fromDescription(TextLinkifier.java:70)
	at org.schabi.newpipe.util.text.TextEllipsizer.linkifyContentView(TextEllipsizer.java:166)
	at org.schabi.newpipe.util.text.TextEllipsizer.setContent(TextEllipsizer.java:62)
	at org.schabi.newpipe.info_list.holder.CommentInfoItemHolder.updateFromItem(CommentInfoItemHolder.java:127)
	at org.schabi.newpipe.info_list.InfoListAdapter.onBindViewHolder(InfoListAdapter.java:337)
	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7747)
	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7847)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6646)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6917)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6757)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6753)
	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
	at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4645)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4348)
	at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4919)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at androidx.viewpager.widget.ViewPager.onLayout(ViewPager.java:1775)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at com.google.android.material.appbar.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:149)
	at com.google.android.material.appbar.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:43)
	at com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:2381)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
	at com.google.android.material.bottomsheet.BottomSheetBehavior.onLayoutChild(BottomSheetBehavior.java:576)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:799)
	at android.view.View.layout(View.java:23798)
	at android.view.ViewGroup.layout(ViewGroup.java:6413)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4118)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3459)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2371)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9297)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
	at android.view.Choreographer.doCallbacks(Choreographer.java:899)
	at android.view.Choreographer.doFrame(Choreographer.java:832)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7924)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)


@Stypox
Copy link
Member Author

Stypox commented Apr 3, 2024

It's fixed on the extractor dev, but again the comments fix branch which the RC was based on is some commits behind dev

@prasetyodedy

This comment was marked as off-topic.

@opusforlife2

This comment was marked as off-topic.

@minecraftchest1
Copy link

I can only view one page of comments now. This was not the case in 0.26.1

@AudricV
Copy link
Member

AudricV commented Apr 6, 2024

If that's for YouTube, that's a mistake from my side that I fixed in the extractor code. See TeamNewPipe/NewPipeExtractor#1163 (comment).

@opusforlife2

This comment was marked as off-topic.

@FranciscoPombal
Copy link

Raising awareness for #10746, please take a look at it for this release if possible.

I know it's possible to add NewPipe's own repo as a workaround, but that's some additional friction for less tech savvy users and it's just more convenient if it's available in the default repo.

As of writing, the latest version available on f-droid's default repo is 0.25.2.

@fenopa

This comment was marked as off-topic.

@AudricV

This comment was marked as off-topic.

@Stypox
Copy link
Member Author

Stypox commented Apr 7, 2024

RC2 landed:

  • fixed not loading more comments
  • fixed crash when old comment layout is provided by YouTube (i.e. the NullPointerException above), since now the NewPipeExtractor is up-to-date

Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC2_release.zip

@NewNewPipe
Copy link

NewNewPipe commented Apr 8, 2024

It looks like more comments are already loaded in RC2, whether all of them I don't know yet.

Thanks for launching the functionality
in the comments section about displaying replies to comments.

I am still very much missing the record of comments to the file. For now, I am assisting in other ways.

@JohhanSam
Copy link

Exception

  • User Action: requested feed
  • Request:
  • Content Country: GB
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.27.0
  • OS: Linux Android 12 - 31
Crash log

org.schabi.newpipe.local.feed.service.FeedLoadService$RequestException: 0:https://www.youtube.com/channel/UC0vBXGSyV14uvJ4hECDOl0Q
	at org.schabi.newpipe.local.feed.service.FeedLoadManager.loadStreams(FeedLoadManager.kt:229)
	at org.schabi.newpipe.local.feed.service.FeedLoadManager.access$loadStreams(FeedLoadManager.kt:33)
	at org.schabi.newpipe.local.feed.service.FeedLoadManager$startLoading$7.apply(FeedLoadManager.kt:113)
	at org.schabi.newpipe.local.feed.service.FeedLoadManager$startLoading$7.apply(FeedLoadManager.kt:112)
	at io.reactivex.rxjava3.internal.operators.parallel.ParallelMap$ParallelMapSubscriber.onNext(ParallelMap.java:116)
	at io.reactivex.rxjava3.internal.operators.parallel.ParallelFilter$ParallelFilterSubscriber.tryOnNext(ParallelFilter.java:132)
	at io.reactivex.rxjava3.internal.operators.parallel.ParallelRunOn$RunOnConditionalSubscriber.run(ParallelRunOn.java:399)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:307)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: java.lang.NullPointerException
	at org.schabi.newpipe.local.feed.service.FeedUpdateInfo.<init>(FeedUpdateInfo.kt:39)
	at org.schabi.newpipe.local.feed.service.FeedLoadManager.loadStreams(FeedLoadManager.kt:220)
	... 13 more


@opusforlife2
Copy link
Collaborator

@Stypox Notif buttons work now! Still, it would be good to confirm with someone using A12-.

@Stypox
Copy link
Member Author

Stypox commented Apr 9, 2024

Exception: User Action: requested feed

@JohhanSam that's not a regression (i.e. it was there even in 0.26.1, see #10863). Anyway, could you test #10957?

it's not possible to watch anything on recent releases at all for a couple of days. It always crashes. Nightly 97 is the last one working I think. 97 to 111 are all crashing at all times.

@fenopa could you provide more information on the crash you are experiencing, and open an issue for it? Since nightly 97 was the same as release 0.26.0, this is also not a regression though.

player notification buttons don't work. android 12.

@NaN-Sz I can reproduce with RC1, but now I can't with RC2. Can you confirm that this is the case? I think Android Studio messed up the package name in BuildConfig since I forgot to "Sync project with Gradle files" which caused intents to refer to the wrong package name, or something like that (can't be sure though)

@AudricV
Copy link
Member

AudricV commented Apr 9, 2024

Rotating your device outside of the app when the comment replies view was the last view shown makes the app crash. Here is a video which shows the problem:

Comments.replies.0.27.0.RC2.crash.mp4
Stacktrace captured with Scoop
FATAL EXCEPTION: main
Process: org.schabi.newpipe.debug.release0270, PID: 7683
java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.List org.schabi.newpipe.extractor.comments.CommentsInfoItem.getUploaderAvatars()' on a null object reference
	at org.schabi.newpipe.fragments.list.comments.CommentRepliesFragment.lambda$getListHeaderSupplier$1(CommentRepliesFragment.java:83)
	at org.schabi.newpipe.fragments.list.comments.CommentRepliesFragment.$r8$lambda$ZCpsyvbpSBAi7u7hr8uTSdFpL6M(Unknown Source:0)
	at org.schabi.newpipe.fragments.list.comments.CommentRepliesFragment$$ExternalSyntheticLambda1.get(Unknown Source:2)
	at org.schabi.newpipe.info_list.InfoListAdapter.onCreateViewHolder(InfoListAdapter.java:291)
	at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7788)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6873)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6757)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6753)
	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
	at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4645)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4348)
	at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4919)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:919)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:807)
	at android.view.View.layout(View.java:24722)
	at android.view.ViewGroup.layout(ViewGroup.java:6450)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4485)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3786)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2659)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9789)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1399)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1408)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1008)
	at android.view.Choreographer.doFrame(Choreographer.java:938)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1382)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8501)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

Device: Google Pixel 7a running Android 14 QPR stock ROM

(The ErrorReportActivity doesn't open, so I don't have a generated error report.)

@NaN-Sz
Copy link

NaN-Sz commented Apr 9, 2024

 I can reproduce with RC1, but now I can't with RC2. Can you confirm that this is the case?

Yes, buttons are working perfectly now.

@B0pol
Copy link
Member

B0pol commented Apr 11, 2024

Timestamps in comment replies are not clickable

https://www.youtube.com/watch?v=GKh2LdXNU3g

@armelolsens2496
2:10 incroyable ❤😭

It’s clickable in comment views, but if you click on replies it isn’t anymore.

I'm not sure how actual comment replies behave (i.e. replies to a comment, what i said is reply to video but in comment replies view), I couldn’t find one

@TheCRISTLAD
Copy link

im import my preferences/config, I passed all my configuration without any problem

@js290

This comment was marked as off-topic.

@JamesClarke7283

This comment was marked as off-topic.

@Stypox
Copy link
Member Author

Stypox commented Apr 12, 2024

@B0pol your issue is actually already fixed after the latest merged changes in TeamNewPipe/NewPipeExtractor#1163, we'll publish a new RC soon

@comminux

This comment was marked as off-topic.

@n-buna404 n-buna404 mentioned this issue Apr 15, 2024
6 tasks
@chris122380

This comment was marked as off-topic.

@Growebis

This comment was marked as off-topic.

@lnee94

This comment was marked as off-topic.

@jpggithub
Copy link

Android 11, Lineageos 18.1, Lenovo P2
Newpipe 0.27.0 RC3 works well including tree comments.
Thank you!

@rambonette
Copy link

Android 10, /e/ OS 18.1, Xiaomi Redmi Note 8T
Work flawlessly!
Nice job 👍

@stellarkookies
Copy link

stellarkookies commented Apr 20, 2024

Android 14, LineageOS 21, Pixel 4a 5G (bramble)
Have used 0.27.0 RC3 for about a week now. No noticeable regressions or serious issues.
Comments load properly, as well as comment trees.
Content loading is also very consistent; much better than in the current stable release.
Thanks for the good work y'all do. Looking forward to the official release :)

@Stypox
Copy link
Member Author

Stypox commented Apr 20, 2024

New RC, includes small YouTube bugfixes from TeamNewPipe/NewPipeExtractor#1168

Release APK (built and signed by @Stypox): NewPipe_v0.27.0_RC4_release.zip
Debug APK (built by our CI in #10929): NewPipe_v0.27.0_RC4_debug.zip

@millionsofplayers

This comment was marked as resolved.

@acrodemocide

This comment was marked as resolved.

@rambonette

This comment was marked as resolved.

@somos61
Copy link

somos61 commented Apr 22, 2024

0.27.0_RC crashes trying to download with SAF turned off in settings. When SAF is on, everything is fine, but the download path in settings looks weird, like content://com.android.externalstorage.documents/tree/primary:Download. Instead of /storage/emulated/0/Download, when SAF is off, but crashes.

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.27.0
  • OS: Linux Android 7.1.2 - 25
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.content.Context.getSystemService(java.lang.String)' on a null object reference
	at org.schabi.newpipe.streams.io.StoredDirectoryHelper.getFreeMemory(StoredDirectoryHelper.java:186)
	at org.schabi.newpipe.download.DownloadDialog.prepareSelectedDownload(DownloadDialog.java:864)
	at org.schabi.newpipe.download.DownloadDialog.lambda$initToolbar$1(DownloadDialog.java:353)
	at org.schabi.newpipe.download.DownloadDialog.$r8$lambda$eftfC3lumhpNMhhwp_4dKbyeS0U(DownloadDialog.java:0)
	at org.schabi.newpipe.download.DownloadDialog$$ExternalSyntheticLambda13.onMenuItemClick(R8$$SyntheticClass:0)
	at androidx.appcompat.widget.Toolbar$1.onMenuItemClick(Toolbar.java:225)
	at androidx.appcompat.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected(ActionMenuView.java:781)
	at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:836)
	at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:159)
	at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:987)
	at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:977)
	at androidx.appcompat.widget.ActionMenuView.invokeItem(ActionMenuView.java:625)
	at androidx.appcompat.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:156)
	at android.view.View.performClick(View.java:5637)
	at android.view.View$PerformClick.run(View.java:22429)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6121)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)


@fighuass
Copy link

Fixes comments on videos not loading and videos suddenly not working since a short bit ago or so on my end.

@IMMalebolgia
Copy link

Have tested on a few different FireStick 4k and 4k Max units and have had no issues at all, great work.

@crapnicki

This comment was marked as off-topic.

@opusforlife2

This comment was marked as off-topic.

@crapnicki

This comment was marked as off-topic.

@DLL125

This comment was marked as off-topic.

@privacyonly

This comment was marked as outdated.

@raananelefant

This comment was marked as outdated.

@TeamNewPipe TeamNewPipe locked as resolved and limited conversation to collaborators Apr 24, 2024
@TobiGr TobiGr unpinned this issue May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests