Feature/issue 373 improve testing for jupiter #827
Conversation
|
|
||
| public class GuaranteedFieldRealTest extends ScenarioTest<GuaranteedFieldRealTest.RealGiven, GuaranteedFieldRealTest.RealWhen, GuaranteedFieldRealTest.RealThen> { | ||
| @ExtendWith(JGivenReportExtractingExtension.class) |
There was a problem hiding this comment.
probably not necessary, we don't test these with JUnit5
There was a problem hiding this comment.
also, we should probably move those into core at some point
| } | ||
|
|
||
| @Override | ||
| public String getFailureMessage(int i) { |
There was a problem hiding this comment.
Explain better how these failure message routine came to be
| @@ -2,5 +2,6 @@ | |||
|
|
|||
| public enum TestFramework { | |||
| JUnit, | |||
| JUnit5, | |||
| TestNG | |||
| } | |||
There was a problem hiding this comment.
add empty line for POSIX conformity
| { TestFramework.JUnit }, | ||
| { TestFramework.TestNG }, | ||
| } ); | ||
| return Arrays.stream(TestFramework.values()) |
There was a problem hiding this comment.
try if TestFramework.values() will work just fine.
There was a problem hiding this comment.
Documentation indicates that this won't be the case
l-1squared
force-pushed
the
feature/Issue-373-Improve-testing-for-jupiter
branch
from
160e5e3
to
3d2fc1c
Compare
| } | ||
|
|
||
| @Test | ||
| public void a_succeding_JUnit5_test() { |
|
|
||
| @Test | ||
| @Issue("#25") | ||
| public void test_classes_with_only_ignored_test_result_in_a_valid_report() { |
There was a problem hiding this comment.
Is it somehow possible to give this method some better name? Needed some time to figure out which word groups belong to the same context. Like "test_classes_which_consist_of_only_ignored_tests" or something.
Also update JGiven Framework tests to also test Junit5 Signed-off-by: l-1sqared <[email protected]>
Signed-off-by: l-1sqared <[email protected]>
JUnit5 offers to use the same class instance over several methods. This however is not in line with the scenario concept of JGiven. The JGivenExtension removes the scenario after the exection of each state, resulting in failure if the next scenario is executed on the same instance Moreover, it is unclear how scenarios that share the same instance react when these methods are executed in parallel. In addition, the JUnit 5 testframework tests were adapted. It turns out that when JUnit5 fails on the class level it returns a successful report model for method but a failure for the class level. Signed-off-by: l-1sqared <[email protected]>
l-1squared
force-pushed
the
feature/Issue-373-Improve-testing-for-jupiter
branch
from
3d2fc1c
to
1bc9d4a
Compare
No description provided.