-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we user ReportPortal? #373
Comments
Not yet. I was not even aware of ReportPortal. However, as JGiven has no own test runner, the JUnit or TestNG integration can be used, I think. What else would you expect on top of that? |
Yes, it works with testng, but when using with JGiven the report sent is really minimal, it is basically a pass/fail. I was hoping for something more like the plugin for cucumber where the Gherkin stories appear on report portal. |
I just tried to run it with junit5 - (with reportportal junit5 integration). Unfortunatelly it does not work at all. Well, it does, but all tests are reported as passed. Since junit5 reportportal agent uses junit5 extensions api, it seems that some exceptions are catched by JGiven and not propagated correctly (when using reportportal junit5 agent with non-jgiven tests, it works well) |
I have added fully working code that demostrates the problem, if someone can look at it/debug it/whatever (my java skills are not that good to do it myself). It uses public reportportal demo server, so no need to local installation https://github.com/llipavsky/reportportal-jgiven-example-tests |
Hi, any update on this? Looks like problem is still valid. I'm using: com.tngtech.jgiven jgiven-junit5 1.0.0 |
Hi @marektester , no, we have not yet looked into the issue. I am currently resolving issue #102 :) I might have a look into this one after that. |
Any news? :) |
@mwesox Hi, I managed to carry out a small investigation this morning. The root issue is that JGiven captures all test errors to make sure its machinery runs correctly at all times. For JUnit5 the errors are rethrown in the We are currently experimenting whether it would be feasible to also rethrow the error in the A solution that is also easy to integrate for users appears to require its own ReportPortal integration as of now. I cannot make any promises on that. |
good news: switching the |
With PR #827 we changed the time when JGiven releases the collected errors back to JUnit5. Therefore, with the next update, it should be possible to integrate ReportPortal and JGiven like so: ReportPortal JGiven POC. I will attempt to make this a proper example project. However, having the example project be self-contained and tested with ReportPortal might prove quite the challenge. |
Is it possible to use/send jgiven reports to ReportPortal? Is there a plugin or are there plans to develop one?
The text was updated successfully, but these errors were encountered: