Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assumption errors #1645

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Fix assumption errors #1645

wants to merge 32 commits into from

Commits on Nov 25, 2024

  1. chore(Test framework): switch to using JUnit5 by default for jgiven-t… 

    …ests

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    adb4d6f View commit details
    Browse the repository at this point in the history

  2. fix(Code Quality): Correct testNG test name 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    041851d View commit details
    Browse the repository at this point in the history

  3. fix(Issue-1625): Pass multiple test cases to JGiven test 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    31b2e14 View commit details
    Browse the repository at this point in the history

  4. fix(Issue-1625): Implement test cases with failing assumptions 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d9dbe60 View commit details
    Browse the repository at this point in the history

  5. fix(Issue-1625): Implement test cases with failing assumptions 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0dcc2b9 View commit details
    Browse the repository at this point in the history

  6. chore(Code Quality): replace anonymous class by lambda 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9b6ada0 View commit details
    Browse the repository at this point in the history

  7. fix(Issue-1625): use dedicated JUnit4 errors 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9433083 View commit details
    Browse the repository at this point in the history

  8. fix(Issue-1625): switch back to JUnit4 test execution for now 

    The JUnit 5 Executor uses a thread global scenario holder to handle its scenarios. For some reason that gets called when executing the JUnit 4 tests.

Maybe its a runner issue?

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d8e1395 View commit details
    Browse the repository at this point in the history

  9. fix(Issue-1625): JUnit5 Scenarios run without inheritance 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ed5a644 View commit details
    Browse the repository at this point in the history

  10. fix(Issue-1625): remove list test scenarios 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c46d738 View commit details
    Browse the repository at this point in the history

  11. fix(Issue-1625): cleanup scenario tests 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fdbe05c View commit details
    Browse the repository at this point in the history

  12. fix(Issue-1625): switch back to Junit5 

    junit4 tests in junit5 come with a filter that gets passed to the test execution listeners. Unfortunately they make the result provider record wrong values

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    eeb7791 View commit details
    Browse the repository at this point in the history

  13. fix(Issue-1625): throw out assertJ tests 

    assertJ checks what kind of frameworks are on the classpath (with a preference for testng) and chooses the exception that framework would throw.
Therefore, there is no need to test specifically for assertJ assumptions.

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    858352a View commit details
    Browse the repository at this point in the history

  14. fix(Issue-1625): WIP 

    probably not the right solution

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7d0d190 View commit details
    Browse the repository at this point in the history

  15. fix(Issue-1625): Logging for tests in main 

    to easier read what these tests actually print.
-> consider reverting to noop logger to avoid spamming the log

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d83b8ab View commit details
    Browse the repository at this point in the history

  16. fix(Issue-1625): Throw out junit 5 junit4 converter 

    That produces so many problems, its worth its own PR

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8f92e3b View commit details
    Browse the repository at this point in the history

  17. fix(Issue-1625): Refactor assumptions tests 

    TODO:
* TestNg and JUnit completely ignore all steps taken when an assumption fails, which is WRONG.
* Junit tests interfere with each other
* TestNg and JUnit completely ignore all steps taken when an assumption fails, which is WRONG.

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    57dea8b View commit details
    Browse the repository at this point in the history

  18. fix(Issue-1625): add an example for a failing assumption 

    current state is that a failed assumption is flat out ignored by the report, which is not desireable either

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4c508cc View commit details
    Browse the repository at this point in the history

  19. fix(Issue-1625): add a method in the vicinity of a failing assumption 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d35a800 View commit details
    Browse the repository at this point in the history

  20. fix(Issue-1625): junit and testng should report a scenario with a fai… 

    …ling assumption

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    97e47f3 View commit details
    Browse the repository at this point in the history

  21. fix(Issue-1625): Tentatively implement aborted exception for JUnit 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    38b292d View commit details
    Browse the repository at this point in the history

  22. feat(Issue-1625): Introduce new ABORTED status 

    adapt unit tests

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    07ca80d View commit details
    Browse the repository at this point in the history

  23. feat(Issue-1625): remove duplicated skip exception test 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    22fbc78 View commit details
    Browse the repository at this point in the history

  24. feat(Issue-1625): fix catching pending scenarios as aborted 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    89e90db View commit details
    Browse the repository at this point in the history

  25. feat(Issue-1625): asciidoc generator recognizes aborted status 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4ca044d View commit details
    Browse the repository at this point in the history

  26. feat(Issue-1625): write example tests for aborted scenarios 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    daa63e2 View commit details
    Browse the repository at this point in the history

  27. feat(Issue-1625): process aborted status in asciidoc report 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    76df1cd View commit details
    Browse the repository at this point in the history

  28. fix(Issue-1625): Automatically produce a plain text report for examples 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8124a1d View commit details
    Browse the repository at this point in the history

  29. fix(Issue-1625): Plain text report generator can create the output di… 

    …rectory

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d6198bb View commit details
    Browse the repository at this point in the history

  30. fix(Issue-1625): Usage of Java 21 features in java 11 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7168834 View commit details
    Browse the repository at this point in the history

  31. feat(JGIVEN-2): update html app 

    so that the app can handle the new aborted status

Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ca401c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. chore(JGIVEN-2): update html app to 1.1.2 

    Signed-off-by: l-1squared <[email protected]>
    @l-1squared
    l-1squared committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    89883ae View commit details
    Browse the repository at this point in the history