Fix assumption errors #1645
Open
Fix assumption errors #1645
+728
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-1squared
changed the title
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
from
c25ed73
to
a689199
Compare
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
from
86c00fc
to
a8a259a
Compare
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
3 times, most recently
from
00ba4da
to
15e42bf
Compare
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
from
9855275
to
4fe6c70
Compare
…ests Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
The JUnit 5 Executor uses a thread global scenario holder to handle its scenarios. For some reason that gets called when executing the JUnit 4 tests. Maybe its a runner issue? Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
junit4 tests in junit5 come with a filter that gets passed to the test execution listeners. Unfortunately they make the result provider record wrong values Signed-off-by: l-1squared <[email protected]>
assertJ checks what kind of frameworks are on the classpath (with a preference for testng) and chooses the exception that framework would throw. Therefore, there is no need to test specifically for assertJ assumptions. Signed-off-by: l-1squared <[email protected]>
probably not the right solution Signed-off-by: l-1squared <[email protected]>
to easier read what these tests actually print. -> consider reverting to noop logger to avoid spamming the log Signed-off-by: l-1squared <[email protected]>
That produces so many problems, its worth its own PR Signed-off-by: l-1squared <[email protected]>
TODO: * TestNg and JUnit completely ignore all steps taken when an assumption fails, which is WRONG. * Junit tests interfere with each other * TestNg and JUnit completely ignore all steps taken when an assumption fails, which is WRONG. Signed-off-by: l-1squared <[email protected]>
current state is that a failed assumption is flat out ignored by the report, which is not desireable either Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
…ling assumption Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
adapt unit tests Signed-off-by: l-1squared <[email protected]>
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
from
4fe6c70
to
bc2f232
Compare
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
…rectory Signed-off-by: l-1squared <[email protected]>
Signed-off-by: l-1squared <[email protected]>
so that the app can handle the new aborted status Signed-off-by: l-1squared <[email protected]>
l-1squared
force-pushed
the
fix/Issue-1625-thorough-assumption-handling
branch
from
bc2f232
to
ca401c9
Compare
Signed-off-by: l-1squared <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests
TODO:
[x] update statistics to also account for for aborted scenarios
[x] html app recognizes aborted scenarios
[x] html links aborted scenarios
[x] asciidocs links aborted scenarios
[x] plain text recognizes aborted scenarios
[x] example tests with aborted scenarios