feat: Resolve DSN from runtime in PG Proxy #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
changed the title
Open
github-actions
bot
changed the title
jvmakine
force-pushed
the
juho/module-in-proxy
branch
3 times, most recently
from
6457549
to
0a5f94f
Compare
jvmakine
commented
Nov 22, 2024
| if !ok { | ||
| return "", fmt.Errorf("database %s not found", params["database"]) | ||
| } | ||
| logger.Debugf("Resolved DSN (%s): %s", params["database"], db.Runtime.DSN) |
There was a problem hiding this comment.
Here is where the logic to use a dsn resolver based on provisioned runtime (like type: aws-iam-auth) will be added
jvmakine
force-pushed
the
juho/module-in-proxy
branch
2 times, most recently
from
b635b09
to
b6ca3cb
Compare
jvmakine
force-pushed
the
juho/module-in-proxy
branch
from
ae113f2
to
51279db
Compare
jvmakine
force-pushed
the
juho/module-in-proxy
branch
2 times, most recently
from
262c532
to
1aa21bb
Compare
jvmakine
force-pushed
the
juho/module-in-proxy
branch
3 times, most recently
from
6ea7f5b
to
7d19c0b
Compare
stuartwdouglas
approved these changes
Nov 25, 2024
Instead, when GetDatabase in the runner is called, and there is no DSN for the DB, it gets translated to pgproxy DSN. We start the pgproxy before the deployment in the runner, and pass the local address in an environment variable to the runner. pgproxy gets the active schema, and redirects connections to the DSN defined in the runtime of that schema. Follow-ups - Integrate MySQL proxy - Remove DSNs from ModuleContext completely
jvmakine
force-pushed
the
juho/module-in-proxy
branch
from
7d19c0b
to
b820db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level changes:
ModuleContextto the runners.GetDatabasein the runner is called, and there is no DSN for the DB, it gets translated to pgproxy DSN.Follow-ups
ModuleContextcompletely