Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resolve DSN from runtime in PG Proxy #3458

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: Resolve DSN from runtime in PG Proxy #3458

merged 1 commit into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. Stop sending PostgreSQL DSNs with the ModuleContext to the runners. 

    Instead, when GetDatabase in the runner is called, and there is no DSN for the DB, it gets translated to pgproxy DSN.

We start the pgproxy before the deployment in the runner, and pass the local address in an environment variable to the runner.
pgproxy gets the active schema, and redirects connections to the DSN defined in the runtime of that schema.

Follow-ups
- Integrate MySQL proxy
- Remove DSNs from ModuleContext completely
    @jvmakine
    jvmakine committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b820db9 View commit details
    Browse the repository at this point in the history