minor #941 Move Parameters to another file (TheMilek)

This PR was merged into the 1.12 branch. Discussion ---------- Commits ------- Move Parameters to another file Exclude Symfony 6 build with php 8.0
Sylius · Feb 6, 2024 · bf7284b · bf7284b
2 parents 2eb9580 + bcbe2e5
commit bf7284b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -31,6 +31,10 @@ jobs:
                 symfony: ["^5.4", "^6.0"]
                 node: ["16.x"]
                 mysql: ["5.7", "8.0"]
+                exclude:
+                    -
+                        php: "8.0"
+                        symfony: "^6.0"
 
         env:
             APP_ENV: test_cached

diff --git a/config/packages/_sylius.yaml b/config/packages/_sylius.yaml
@@ -6,6 +6,7 @@ imports:
 
     - { resource: "@SyliusShopBundle/Resources/config/app/config.yml" }
     - { resource: "@SyliusPayPalPlugin/Resources/config/config.yaml" }
+    - { resource: "../parameters.yaml" }
 
 parameters:
     sylius_core.public_dir: '%kernel.project_dir%/public'

diff --git a/config/parameters.yaml b/config/parameters.yaml
@@ -0,0 +1,2 @@
+parameters:
+    locale: en_US
diff --git a/config/services.yaml b/config/services.yaml
@@ -1,8 +1,3 @@
-# Put parameters here that don't need to change on each machine where the app is deployed
-# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
-parameters:
-    locale: en_US
-
 services:
     # Default configuration for services in *this* file
     _defaults: