Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist **empty** for skybox #25

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

wrefgtzweve
Copy link
Contributor

@wrefgtzweve wrefgtzweve commented Dec 28, 2024

Currently flying a helicopter into the skybox can still result in the rotor breaking off, also makes it return early so damage isn't applied twice.

This for example would trigger the bug
image

An example trace of the case above

["AllSolid"]	=	false
["Contents"]	=	1
["DispFlags"]	=	0
["Entity"]	=	Entity [0][worldspawn]
["Fraction"]	=	1
["FractionLeftSolid"]	=	0.32773450016975
["Hit"]	=	true
["HitBox"]	=	0
["HitGroup"]	=	0
["HitNoDraw"]	=	false
["HitNonWorld"]	=	false
["HitNormal"]	=	0.000000 0.000000 0.000000
["HitPos"]	=	-5493.462891 5308.244629 2849.267822
["HitSky"]	=	false
["HitTexture"]	=	**empty**
["HitWorld"]	=	true
["MatType"]	=	67
["Normal"]	=	-0.784633 0.404783 -0.469576
["PhysicsBone"]	=	0
["StartPos"]	=	-5322.031250 5219.805176 2951.863770
["StartSolid"]	=	true
["SurfaceFlags"]	=	0
["SurfaceProps"]	=	0

I think what's happening is that the trace starts in the world so it hits a inside of a brush.

@StyledStrike StyledStrike merged commit f593d15 into StyledStrike:main Dec 28, 2024
1 check passed
@StyledStrike StyledStrike added the bugfix Fixes issues label Dec 28, 2024
@wrefgtzweve wrefgtzweve deleted the fix-skybox-hittexture branch December 28, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants