Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2399 update rules tags #4553

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

maksim-grebeniuk-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It must have been a cumbersome PR to create :-)
I put it back in progress, but there are only minor changes.

rules/S1129/python/metadata.json Show resolved Hide resolved
rules/S1143/python/metadata.json Show resolved Hide resolved
rules/S1244/python/metadata.json Outdated Show resolved Hide resolved
rules/S3699/python/metadata.json Outdated Show resolved Hide resolved
rules/S5719/python/metadata.json Show resolved Hide resolved
rules/S6794/python/metadata.json Show resolved Hide resolved
Copy link

sonarqube-next bot commented Dec 4, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Dec 4, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomas-serre-sonarsource thomas-serre-sonarsource merged commit e0ab6ac into master Dec 4, 2024
15 checks passed
@thomas-serre-sonarsource thomas-serre-sonarsource deleted the mg/SONARPY-2399 branch December 4, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants