SONARPY-2399 update rules tags

SonarSource · Dec 3, 2024 · 45b01ab · 45b01ab
1 parent a007e43
commit 45b01ab
Show file tree

Hide file tree

Showing 136 changed files with 364 additions and 93 deletions.
diff --git a/rules/S1045/python/metadata.json b/rules/S1045/python/metadata.json
@@ -1,3 +1,6 @@
 {
-  "title": "All \"except\" blocks should be able to catch exceptions"
+  "title": "All \"except\" blocks should be able to catch exceptions",
+  "tags": [
+    "suspicious"
+  ]
 }
diff --git a/rules/S1128/python/metadata.json b/rules/S1128/python/metadata.json
@@ -1,5 +1,9 @@
 {
   "defaultQualityProfiles": [
 
+  ],
+  "tags": [
+    "convention",
+    "unused"
   ]
 }
diff --git a/rules/S1129/python/metadata.json b/rules/S1129/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "2min"
   },
   "tags": [
-
+    "convention"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1143/python/metadata.json b/rules/S1143/python/metadata.json
@@ -1,3 +1,8 @@
 {
-  "title": "Break, continue and return statements should not occur in \"finally\" blocks"
+  "title": "Break, continue and return statements should not occur in \"finally\" blocks",
+  "tags": [    
+    "cwe",
+    "error-handling",
+    "pitfall"
+  ]
 }
diff --git a/rules/S1144/python/metadata.json b/rules/S1144/python/metadata.json
@@ -1,3 +1,6 @@
 {
-  "title": "Unused class-private methods should be removed"
+  "title": "Unused class-private methods should be removed",
+  "tags": [
+    "suspicious"
+  ]
 }
diff --git a/rules/S1226/python/metadata.json b/rules/S1226/python/metadata.json
@@ -1,3 +1,6 @@
 {
-  "title": "Function parameters initial values should not be ignored"
+  "title": "Function parameters initial values should not be ignored",
+  "tags": [
+    "suspicious"
+  ]
 }
diff --git a/rules/S124/python/metadata.json b/rules/S124/python/metadata.json
@@ -1,3 +1,6 @@
 {
-  "sqKey": "CommentRegularExpression"
+  "sqKey": "CommentRegularExpression",
+  "tags": [
+    "convention"
+  ]
 }
diff --git a/rules/S1244/python/metadata.json b/rules/S1244/python/metadata.json
@@ -13,7 +13,10 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "suspicious",
+    "numpy",
+    "pytourch",
+    "data-science"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1311/metadata.json b/rules/S1311/metadata.json
@@ -9,7 +9,7 @@
     "linearFactor": "1min"
   },
   "tags": [
-
+    "brain-overload"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1313/python/metadata.json b/rules/S1313/python/metadata.json
@@ -1,3 +1,5 @@
 {
-
+  "tags": [
+    "bad-practice"
+  ]
 }
diff --git a/rules/S1451/metadata.json b/rules/S1451/metadata.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+     "convention"
+  ],
   "extra": {
     "replacementRules": [],
     "legacyKeys": [

diff --git a/rules/S1523/python/metadata.json b/rules/S1523/python/metadata.json
@@ -1,4 +1,7 @@
 {
   "status": "deprecated",
-  "quickfix": "unknown"
+  "quickfix": "unknown",
+  "tags": [
+    "deprecated"
+  ]
 }
diff --git a/rules/S1542/python/metadata.json b/rules/S1542/python/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "convention",
+    "pep"
+  ]
 }
diff --git a/rules/S1656/python/metadata.json b/rules/S1656/python/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "convention",
+    "confusing"
+  ]
 }
diff --git a/rules/S1716/python/metadata.json b/rules/S1716/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "10min"
   },
   "tags": [
-
+    "pitfall"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1717/python/metadata.json b/rules/S1717/python/metadata.json
@@ -7,7 +7,7 @@
     "constantCost": "2min"
   },
   "tags": [
-
+    "deprecated"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1720/python/metadata.json b/rules/S1720/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "convention"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1721/python/metadata.json b/rules/S1721/python/metadata.json
@@ -7,7 +7,7 @@
     "constantCost": "1 min"
   },
   "tags": [
-
+    "deprecated"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1751/metadata.json b/rules/S1751/metadata.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "confusing",
+    "bad-practice"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1764/metadata.json b/rules/S1764/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "2min"
   },
   "tags": [
-
+    "suspicious"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S1845/python/metadata.json b/rules/S1845/python/metadata.json
@@ -1,3 +1,7 @@
 {
-  "title": "Methods and field names should not differ only by capitalization"
+  "title": "Methods and field names should not differ only by capitalization",
+  "tags": [
+    "confusing",
+    "convention"
+  ]
 }
diff --git a/rules/S1908/python/metadata.json b/rules/S1908/python/metadata.json
@@ -1,3 +1,4 @@
 {
-  "sqKey": "FileComplexity"
+  "sqKey": "FileComplexity",
+  "tags": ["brain-overload"]
 }
diff --git a/rules/S2092/python/metadata.json b/rules/S2092/python/metadata.json
@@ -1,3 +1,9 @@
 {
-
+  "tags": [
+    "cwe",
+    "privacy",
+    "fastapi",
+    "django",
+    "flask"
+  ]
 }
diff --git a/rules/S2159/python/metadata.json b/rules/S2159/python/metadata.json
@@ -5,5 +5,8 @@
     },
     "attribute": "LOGICAL"
   },
-  "defaultSeverity": "Blocker"
+  "defaultSeverity": "Blocker",
+  "tags": [
+    "suspicious"
+  ]
 }
diff --git a/rules/S2201/metadata.json b/rules/S2201/metadata.json
@@ -13,7 +13,8 @@
     "constantCost": "10min"
   },
   "tags": [
-
+    "suspicious",
+    "confusing"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2208/python/metadata.json b/rules/S2208/python/metadata.json
@@ -1,5 +1,9 @@
 {
   "defaultQualityProfiles": [
     "Sonar way"
+  ],
+  "tags": [
+    "pitfall",
+    "bad-practice"
   ]
 }
diff --git a/rules/S2257/python/metadata.json b/rules/S2257/python/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "cwe",
+    "bad-practice"
+  ]
 }
diff --git a/rules/S2275/python/metadata.json b/rules/S2275/python/metadata.json
@@ -1,3 +1,6 @@
 {
-  "title": "String formatting should not lead to runtime errors"
+  "title": "String formatting should not lead to runtime errors",
+  "tags": [
+    "pitfall"
+  ]
 }
diff --git a/rules/S2319/python/metadata.json b/rules/S2319/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "convention"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2711/python/metadata.json b/rules/S2711/python/metadata.json
@@ -12,7 +12,10 @@
     "func": "Constant\/Issue",
     "constantCost": "15min"
   },
-  "tags": [],
+  "tags": [
+    "pitfall",
+    "syntax"
+  ],
   "extra": {
     "replacementRules": [],
     "legacyKeys": []

diff --git a/rules/S2712/python/metadata.json b/rules/S2712/python/metadata.json
@@ -12,7 +12,11 @@
     "func": "Constant\/Issue",
     "constantCost": "15min"
   },
-  "tags": [],
+  "tags": [
+    "pitfall",
+    "python3",
+    "syntax"
+  ],
   "extra": {
     "replacementRules": [],
     "legacyKeys": []

diff --git a/rules/S2733/python/metadata.json b/rules/S2733/python/metadata.json
@@ -7,7 +7,7 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "pitfall"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2734/python/metadata.json b/rules/S2734/python/metadata.json
@@ -7,7 +7,8 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "convention",
+    "pitfall"
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2734",

diff --git a/rules/S2757/python/metadata.json b/rules/S2757/python/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "confusing",
+    "convention"
+  ]
 }
diff --git a/rules/S2761/python/metadata.json b/rules/S2761/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "5min"
   },
   "tags": [
-
+    "confusing"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2772/python/metadata.json b/rules/S2772/python/metadata.json
@@ -13,7 +13,7 @@
     "constantCost": "2min"
   },
   "tags": [
-    "unused"
+    "confusing"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2823/python/metadata.json b/rules/S2823/python/metadata.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "1min"
   },
-  "tags": [],
+  "tags": [
+    "python3"
+  ],
   "extra": {
     "replacementRules": [],
     "legacyKeys": []

diff --git a/rules/S2876/python/metadata.json b/rules/S2876/python/metadata.json
@@ -12,7 +12,10 @@
     "func": "Constant\/Issue",
     "constantCost": "10min"
   },
-  "tags": [],
+  "tags": [
+    "python3",
+    "pep"
+  ],
   "extra": {
     "replacementRules": [],
     "legacyKeys": []

diff --git a/rules/S3329/python/metadata.json b/rules/S3329/python/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "cwe",
+    "bad-practice"
+  ]
 }
diff --git a/rules/S3330/python/metadata.json b/rules/S3330/python/metadata.json
@@ -1,3 +1,9 @@
 {
-
+  "tags": [
+    "cwe",
+    "privacy",
+    "flask",
+    "fastapi",
+    "django"
+  ]
 }
diff --git a/rules/S3403/python/metadata.json b/rules/S3403/python/metadata.json
@@ -5,5 +5,10 @@
     },
     "attribute": "LOGICAL"
   },
-  "defaultSeverity": "Blocker"
+  "defaultSeverity": "Blocker",
+  "tags": [
+    "confusing",
+    "pitfall",
+    "typing"
+  ]
 }
diff --git a/rules/S3516/python/metadata.json b/rules/S3516/python/metadata.json
@@ -1,3 +1,7 @@
 {
-  "title": "Functions returns should not be invariant"
+  "title": "Functions returns should not be invariant",
+  "tags": [
+    "confusing",
+    "design"
+  ]
 }