JS-420 [DO NOT SQUASH] Fix ITs: plugin_qa_sq_dev & eslint_plugin_test #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
kebetsi
force-pushed
the
fix-ITs-change-SQ-version
branch
from
3debd62 to
40acd28
Compare
kebetsi
changed the title
… instead of "DEV"
…ks (for some decorated rules)
kebetsi
force-pushed
the
fix-ITs-change-SQ-version
branch
from
fe0a7b0 to
621c900
Compare
kebetsi
changed the title
kebetsi
changed the title
|
saberduck
reviewed
Nov 20, 2024
| @@ -310,11 +310,11 @@ eslint_plugin_test_task: | |||
| - source set_maven_build_version $BUILD_NUMBER | |||
| - npm run eslint-plugin:build | |||
| - cd its/eslint8-plugin-sonarjs | |||
| - npm run build | |||
| - npm install | |||
There was a problem hiding this comment.
should we use npm ci instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-420