Skip to content

Commit

Permalink
Fix ITs eslint_plugin_test: Limit ESLint version to 9.14 as 9.15 brea…
Browse files Browse the repository at this point in the history
…ks (for some decorated rules)
  • Loading branch information
kebetsi committed Nov 20, 2024
1 parent eaf7b02 commit 621c900
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,11 @@ eslint_plugin_test_task:
- source set_maven_build_version $BUILD_NUMBER
- npm run eslint-plugin:build
- cd its/eslint8-plugin-sonarjs
- npm run build
- npm install
- npx tsc --noEmit # check typings for tseslint.config.ts
- npm run test
- cd ../eslint9-plugin-sonarjs
- npm run build
- npm install
- npx tsc --noEmit # check typings for tseslint.config.ts
- npm run test

Expand All @@ -338,7 +338,7 @@ eslint8_node16_plugin_test_task:
- source set_maven_build_version $BUILD_NUMBER
- npm run eslint-plugin:build
- cd its/eslint8-plugin-sonarjs
- npm run build
- npm install
- npx tsc --noEmit # check typings for tseslint.config.ts
- npm run test

Expand Down
4 changes: 2 additions & 2 deletions generate-eslint-package-json.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import fs from 'node:fs/promises';
import { join, dirname } from 'path';
import { dirname, join } from 'path';
import { fileURLToPath } from 'node:url';

const eslintPluginDependencies = [
Expand Down Expand Up @@ -74,7 +74,7 @@ await fs.writeFile(
'https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md',
dependencies,
peerDependencies: {
eslint: '^8.0.0 || ^9.0.0',
eslint: '8.0.0 - 9.14',
},
},
null,
Expand Down
2 changes: 1 addition & 1 deletion its/eslint8-plugin-sonarjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"name": "eslint8-plugin-sonarjs-tests",
"description": "Test suite for eslint-plugin-sonarjs",
"scripts": {
"build": "npm install && cp ../../lib/eslint-plugin-sonarjs-* ./plugin.tgz && npm i ./plugin.tgz --no-save && rm -f plugin.tgz",
"test": "node index.test.js"
},
"devDependencies": {
"eslint-plugin-sonarjs": "file:../../lib/eslint-plugin-sonarjs-0.0.0-SNAPSHOT.tgz",
"@types/eslint": "^8.56.12",
"cross-spawn": "7.0.3",
"eslint": "8.57.0",
Expand Down
4 changes: 2 additions & 2 deletions its/eslint9-plugin-sonarjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"name": "eslint9-plugin-sonarjs-tests",
"description": "Test suite for eslint-plugin-sonarjs",
"scripts": {
"build": "npm install && cp ../../lib/eslint-plugin-sonarjs-* ./plugin.tgz && npm i ./plugin.tgz --no-save && rm -f plugin.tgz",
"test": "node index.test.js"
},
"devDependencies": {
"eslint-plugin-sonarjs": "file:../../lib/eslint-plugin-sonarjs-0.0.0-SNAPSHOT.tgz",
"cross-spawn": "7.0.3",
"eslint": "^9.10.0",
"eslint": "9 - 9.14",
"typescript": "5.5.4",
"typescript-eslint": "^8.5.0"
}
Expand Down

0 comments on commit 621c900

Please sign in to comment.