[Do Not Merge] - [WIP] OpenJDK 11 Upgrades #221
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should REALLY specify which version of Java we are targeting, or at least using for development. Luckily the current version of OpenJDK worked for me, but we should still note it somewhere.
Update README.md
Long() -> Long.valueOf() Type restrict Hashtable
Added types to Tempaltes
Serial IDs Template Declarations with Types
Commented out code that is not needed. removed import not being used. Updated Advantages to conform to type.
Static types for tempaltes
Commenting out code not being used.
Corrected type for abUnitData
Type enforcement for methods
Added Serial Version ID Removed warning supression
- Removed warning supression - Added Serial Version UID
- Added Serial Version UID
- Added Serial Version UID - Removed warning supression
My editor seems to remove extra spaces from the ends of lines
Instead of Mech since this is for SAW
Use SAW Prefs and make the options match. Clear the "Selected Variant" dropdown. Manage the Lock Chassis button correctly.
For the Roster sheet, this will break up a long name into two lines. Also pushed the tonnage away from the unit type a bit more so that "Combat Vehicle" wouldn't overlap.
And now can handle multiple lines for each and then adds just a bit more space under the line so it doesn't feel quite so squished.
So that it sets the buttons and comboboxes correctly.
When it shouldn't be enabled.
I had slightly different code, now matching what the other code is doing.
…fb_roster Updated Roster Printing Code
…electunits Select Unit screen update
…awgui SAW GUI Fixes
Will load and process all files in the directory (and any subdirectory)
So that it doesn't jump around everywhere.
and if it is...do not show the message pop-up.
Convert from isBlank to a length check after trim.
before trying to access the height property.
…onvertdirectory_tomtf Add button to convert to MTF
…elease-changes drafting release notes
…ocol_error Fix protocol error on Linux when opening files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working through the warnings, errors, and notices in VS Code to prep the codebase for a transition to OpenJDK 11.
Each commit is limited to each file, if possible. (apologies for the commit messages as they should have been more verbose from the beginning).