Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do Not Merge] - [WIP] OpenJDK 11 Upgrades #221
base: jdk11
Are you sure you want to change the base?
[Do Not Merge] - [WIP] OpenJDK 11 Upgrades #221
Changes from all commits
8f85515
9b11e34
31df52c
b264c88
67cd60b
673740a
05dd185
d100444
3de32a4
b3622a6
591539c
6ecb187
5d444f6
8c7230d
7b71636
ada6e6d
d4bf9c8
34b4a3d
d11473b
91fa1d8
9efb541
7027945
d3b0ff3
05375a8
349c07f
8dd7d55
9410b4a
add9ef2
ce252bd
29566dd
ebc9b44
2edfa04
7d66da9
08621f7
9b1aa44
56a92ae
db8a1f0
561bf18
352dda1
4c76280
6b19cd8
1ff6ac3
6ae2a4e
48d36a9
8b5d1de
2ba43a7
f0a3e98
eba7395
e8d8a13
3e23673
6f482cf
def2412
5895f1b
c47a176
befb4cd
a51fdb4
214f93b
5855693
078fc9b
d5d2709
4f79d46
d8b8b45
3f7ed20
5e91af9
23aa8a9
bbd0dc2
468faa6
1b0d3f2
fe48a8b
3cfac45
ca41857
216a0f5
2f0c5fc
bec23e4
42a49ab
d8df765
82cbd7b
9477df3
67e4d8f
3b70ef9
e85cf9a
034527c
b21f0ee
6279757
7fc9d11
a1b1acf
89d67c3
e826b08
3c42b6b
9e16bbf
4f7670a
05995ee
b19ad33
b09a7ef
522da80
7dabe95
c47db3e
e162b81
6e917de
95f3f61
ce50093
77d8fd9
7489920
65db9a5
5eddf0e
bc345af
5c6c7f9
0d7e865
8e59e27
d272c5f
ce0f02d
70510ba
20e905b
ff308e8
4b9789d
1178244
cc66aa2
028545a
cceeb05
39f36c6
b4e1dca
5323b45
c86d0c2
8e40ae2
6a097a4
d081f89
dc87fa3
041aad4
8adb109
b35c318
796db62
c2cfbdc
b3b7f3f
6649a7b
bee7caf
31d0e06
294b371
fedc0e7
3411a30
6d0dc21
33f7e66
81cd56f
862166a
8ffc28d
6f11baf
6781137
809238d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I found a way to fix these in the form designer, which will allow the updates to persist when editing any dialogs in Netbeans. For example, open BFB/GUI/ForcePanel.java in Netbeans, right click the cmbForceType component, go to Code, and then type
<String>
in the "Type Parameters" box and then save the form:Can you do these for any changes that take place in autogenerated code sections, instead of modifying the Java directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to revert or undo the previous changes, because once you open and save the forms in Netbeans the changes in the autogenerated code sections will be erased anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using NetBeans. Using VS Code. Although that is good to know for future forms y'all mess with. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately Netbeans is required for any changes to GUI code :( I wish there was a way to make it totally IDE-agnostic but it would be too hard for us not to have a form designer.
I only use Netbeans for that purpose, any IDE will work for logic changes that don't happen inside of autogenerated GUI code