Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate stage to the new sdk #2163

Merged
merged 15 commits into from
Nov 13, 2023
Merged

feat: Migrate stage to the new sdk #2163

merged 15 commits into from
Nov 13, 2023

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Oct 30, 2023 •
edited
Loading

Migrated stages to the new SDK + moved set comment in the FileFormat file to the right place, so now options could be reusable in other places without weird comment options.

Test Plan

  • unit tests
  • integration tests

References

Other references

Things TODO in the next PR

  • Introduce commands on stage like PUT, LS, COPY INTO, etc.
  • Replace stage usage in test helper functions
  • Add external stages when we will be able to test them
  • Fix Set Comment in the FileFormat Alter (+ add unit/integration tests that will check the correctness)

@github-actions
Copy link

Integration tests failure for cdceb29b323105694dacee12dcd447272dce3512

github-actions[bot]
github-actions bot reviewed Oct 30, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

pkg/sdk/stages_impl_gen.go|440 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| too many errors) (typecheck)
pkg/sdk/stages_dto_builders_gen.go|160 col 42| method StageCopyOnErrorOptionsRequest.WithSkipFile already declared at pkg/sdk/stages_dto_builders_gen.go:155:42
pkg/sdk/stages_impl_gen.go|139 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|208 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|269 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|301 col 5| unknown field MasterKey in struct literal of type ExternalStageGCSEncryption
pkg/sdk/stages_impl_gen.go|301 col 49| r.ExternalStageParams.Encryption.MasterKey undefined (type *ExternalStageGCSEncryptionRequest has no field or method MasterKey)
pkg/sdk/stages_impl_gen.go|335 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|391 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|440 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| too many errors (typecheck)
pkg/sdk/stages_dto_builders_gen.go|160 col 42| method StageCopyOnErrorOptionsRequest.WithSkipFile already declared at pkg/sdk/stages_dto_builders_gen.go:155:42
pkg/sdk/stages_impl_gen.go|139 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|208 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|269 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|301 col 5| unknown field MasterKey in struct literal of type ExternalStageGCSEncryption
pkg/sdk/stages_impl_gen.go|301 col 49| r.ExternalStageParams.Encryption.MasterKey undefined (type *ExternalStageGCSEncryptionRequest has no field or method MasterKey)
pkg/sdk/stages_impl_gen.go|335 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|391 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|440 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| duplicate field name SkipFile in struct literal
pkg/sdk/stages_impl_gen.go|499 col 13| too many errors) (typecheck)

pkg/sdk/stages_dto_builders_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-stage-to-the-new-sdk branch from cdceb29 to 3c729f7 Compare October 31, 2023 12:56
github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
pkg/sdk/stages_def.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/stages_impl_gen.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 3c729f79795cd8ce188ca87556301cc49db1b95b

@github-actions GitHub Actions
Copy link

Integration tests failure for 8131b060bc823ed8cca8e491957fdb9f6f686679

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-stage-to-the-new-sdk branch from 2f2426e to 236bbce Compare November 6, 2023 08:07
github-actions[bot]
github-actions bot reviewed Nov 6, 2023
View reviewed changes
pkg/sdk/stages_def.go Outdated Show resolved Hide resolved
sfc-gh-jcieslak
sfc-gh-jcieslak commented Nov 6, 2023
View reviewed changes
pkg/sdk/stages_def.go Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review November 6, 2023 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Integration tests failure for 236bbce560fa83218033825cd50fdc43681704b7

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Integration tests failure for 6d3a19dec319b457578c5deae7256902b8b13afe

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 6, 2023
View reviewed changes
pkg/sdk/poc/generator/list_builders.go Outdated Show resolved Hide resolved
pkg/sdk/poc/generator/query_struct.go Show resolved Hide resolved
pkg/sdk/stages_gen_test.go Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this pull request Nov 6, 2023
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Integration tests failure for 0d9a4f7decf3cd31c61bb66f856977651bc884c3

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Integration tests failure for 0d9a4f7decf3cd31c61bb66f856977651bc884c3

sfc-gh-swinkler
sfc-gh-swinkler reviewed Nov 13, 2023
View reviewed changes
pkg/sdk/stages_dto_builders_gen.go Show resolved Hide resolved
pkg/sdk/stages_dto_builders_gen.go Show resolved Hide resolved
pkg/sdk/stages_dto_gen.go Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-stage-to-the-new-sdk branch 2 times, most recently from 379bd7f to 8c0b058 Compare November 13, 2023 08:28
@github-actions GitHub Actions
Copy link

Integration tests failure for 8c0b058fbbbdebbe42cbe026907be8a19856df8a

@github-actions GitHub Actions
Copy link

Integration tests failure for 379bd7f23124c4d43bc47e4953cfe134295aedac

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-stage-to-the-new-sdk branch from 7daba7a to 56f66c0 Compare November 13, 2023 09:57
@github-actions GitHub Actions
Copy link

Integration tests failure for 56f66c0defd0c91b97ad7afd9e4967dcc20db9c7

github-actions[bot]
github-actions bot reviewed Nov 13, 2023
View reviewed changes
pkg/sdk/tasks_def.go Show resolved Hide resolved
pkg/sdk/stages_def.go Show resolved Hide resolved
pkg/sdk/tasks_def.go Show resolved Hide resolved
pkg/sdk/stages_def.go Show resolved Hide resolved
pkg/sdk/tasks_def.go Show resolved Hide resolved
pkg/sdk/stages_def.go Show resolved Hide resolved
pkg/sdk/tasks_def.go Show resolved Hide resolved
pkg/sdk/stages_def.go Show resolved Hide resolved
pkg/sdk/tasks_def.go Show resolved Hide resolved
pkg/sdk/stages_def.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 1ff5f07a47f12fe6a6da1eefaceea9a2eb67443f

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-stage-to-the-new-sdk branch from 1ff5f07 to 3533e9a Compare November 13, 2023 10:34
@github-actions GitHub Actions
Copy link

Integration tests failure for 3533e9a5cb4e76fbc7dd7a077df201b36e2b0579

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 13, 2023 10:53
@github-actions GitHub Actions
Copy link

Integration tests failure for 27b4755a1d356e61a100665476182dcd19fb1e0f

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 1d08c46 into main Nov 13, 2023
7 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the migrate-stage-to-the-new-sdk branch November 13, 2023 12:37
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 13, 2023
Merged
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Nov 14, 2023
Merged
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-swinkler @sfc-gh-asawicki