Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix #1947, #2134, #2173, and #2176 #2192

Merged
merged 8 commits into from
Nov 14, 2023
Merged

fix: Fix #1947, #2134, #2173, and #2176 #2192

merged 8 commits into from
Nov 14, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Nov 14, 2023 •
edited
Loading

Fix several, relatively new, issues.

Fixes:

  • Check if any value is altered before attempting to run an alter statement for the dynamic table
  • Suppress whitespace diff for query parameter in the dynamic table resource
  • Leverage in schema syntax for dynamic table ShowByID method
  • Compute skip_header parameter correctly in the file format resource
  • Check if any value is altered before attempting to run an alter statement for the file format

There is one more problem with file format resource: altering the comment. It was mistakenly removed in the change #1917, but also a new change #2163 messes with AlterFileFormatOptions which requires a bit more of work.

Fixes #1947, fixes #2134, fixes #2173, fixes #2176.

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review November 14, 2023 11:21
@github-actions GitHub Actions
Copy link

Integration tests failure for 6ab5d4858ec9187c43159de784f54a39d677ec84

@github-actions GitHub Actions
Copy link

Integration tests failure for a9a10713f94a9d7a2e1ab9b75d86a91c7100d69c

@github-actions GitHub Actions
Copy link

Integration tests failure for a9a10713f94a9d7a2e1ab9b75d86a91c7100d69c

@sfc-gh-asawicki sfc-gh-asawicki merged commit 98d8ccc into main Nov 14, 2023
7 of 8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-several-small-issues branch November 14, 2023 16:45
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak