feat: database role resource #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/resources/database_role.go
Outdated
| row := snowflake.QueryRow(db, qry) | ||
| // FIXME scan for name as there is LIKE pattern syntax | ||
| databaseRole, err := snowflake.ScanDatabaseRole(row) | ||
| databaseRole.DatabaseName = database // Nasty. |
There was a problem hiding this comment.
not understanding what the point of this is. If database name is a ForceNew attribute then theres no reason to read or overwrite it at all since its never going to change.
| ) | ||
|
|
||
| type ( | ||
| TestAccDatabaseRoleSettings struct { |
There was a problem hiding this comment.
i think this is a bit overkill. probably better to just have a function like databaseRoleConfig(warehouseName, databaseName, roleName)
|
@mlorek this is interesting an highlights a deficiency in the currently provider. we will also need to a |
sfc-gh-swinkler
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added database role resource: #1442
Test Plan
References
https://docs.snowflake.com/en/user-guide/security-access-control-considerations#label-access-control-considerations-database-roles
*