Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for database roles #1442

Closed
cpmub1 opened this issue Dec 29, 2022 · 8 comments
Closed

support for database roles #1442

cpmub1 opened this issue Dec 29, 2022 · 8 comments
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:database_role Issue connected to the snowflake_database_role resource

Comments

@cpmub1
Copy link

cpmub1 commented Dec 29, 2022

snowflake has introduced DATABASE ROLES.
https://docs.snowflake.com/en/sql-reference/sql/create-database-role.html

can support for DATABASE ROLE be introduced ?

@cpmub1 cpmub1 added the feature-request Used to mark issues with provider's missing functionalities label Dec 29, 2022
@bennylu2
Copy link
Contributor

bennylu2 commented Jan 1, 2023

I'm not sure what the policy is for the provider to support features that are in preview

@ghost
Copy link

ghost commented Jan 11, 2023

wholeheartedly wanted this feature, this feature makes data share sooooo much easier to configure and control

@bennylu2
Copy link
Contributor

I can put up a PR for this but I'm unsure what policy is for provider to support features in preview. I'm also unsure of the status of the provider and if there's going to a be a major version release in the near future.

I'd be happy to pick this up if given the go ahead by the maintainers

@cpmub1
Copy link
Author

cpmub1 commented Jan 31, 2023

Thanks @bennylu2
who should give ahead to move on ? Let me try to tag them here or get their attention

@cpmub1
Copy link
Author

cpmub1 commented Jan 31, 2023

Though this feature is said to be in "preview", Snowflake has implemented it on the SNOWFLAKE database & enabled it for all accounts, with no restrictions. More over, almost everyone has their own version of database role, thru custom roles - which does not provide a defined scope boundary across databases.
hence, i strongly believe, Snowflake has it as "preview" for paper-document reasons, rather than for functionality.

@cpmub1
Copy link
Author

cpmub1 commented Apr 7, 2023

@sfc-gh-swinkler I see that you have recently committed some changes to this repo.
Can you please suggest on who can give a go ahead for making this change ?

@bennylu2 was willing to do a PR , but there was no ahead & the effort stopped.

@bgabrhelik-com
Copy link

Now there is the snowflake_database_role resource, however it seems there is not support for granting of database role. Granting model seems to be quit difficult and duplication of all the resources doesn't make sense. There is small difference in the syntax.

  • FQN for role
  • TO DATABASE ROLE abcd;

E.g.
GRANT USAGE ON SCHEMA DB1.PUBLIC TO DATABASE ROLE DB_READ;

@sfc-gh-asawicki
Copy link
Collaborator

sfc-gh-asawicki commented Dec 21, 2023

Closing because done in #1654.

Database role grants are currently being developed (#2159)
.

@sfc-gh-jcieslak sfc-gh-jcieslak added category:resource resource:database_role Issue connected to the snowflake_database_role resource labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:database_role Issue connected to the snowflake_database_role resource
Projects
None yet
Development

No branches or pull requests

5 participants