Revert "Use go 1.21 (#344)" #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04285e2.
sfc-gh-srhodes
approved these changes
Oct 19, 2023
Added! |
sfc-gh-srhodes
added a commit
that referenced
this pull request
Apr 3, 2024
This should unblock some currently pending updates. Each major Go release is supported until there are two newer major releases and the newest major version is 1.22, so 1.19 has been unsupported for a while. We'd previously tried this six months ago and reverted in #357. The cases we had where we wanted an older version should no longer apply. Prometheus libraries (#415) are the current dependency where newer versions need newer go compilers.
Merged
sfc-gh-elinardi
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Bump go.mod to 1.21 This should unblock some currently pending updates. Each major Go release is supported until there are two newer major releases and the newest major version is 1.22, so 1.19 has been unsupported for a while. We'd previously tried this six months ago and reverted in #357. The cases we had where we wanted an older version should no longer apply. Prometheus libraries (#415) are the current dependency where newer versions need newer go compilers. * Address go lint errors * Add in process test changes from #344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 04285e2.
Downgrading to keep the minimum go version for importing sansshell at 1.19.