Bump go.mod to 1.21 (#417)

* Bump go.mod to 1.21

This should unblock some currently pending updates. Each major Go release is supported until there are two newer major releases and the newest major version is 1.22, so 1.19 has been unsupported for a while.

We'd previously tried this six months ago and reverted in #357. The cases we had where we wanted an older version should no longer apply.

Prometheus libraries (#415) are the current dependency where newer versions need newer go compilers.

* Address go lint errors

* Add in process test changes from #344

go.mod

@@ -1,6 +1,6 @@
 module github.com/Snowflake-Labs/sansshell
 
-go 1.19
+go 1.21
 
 require (
 	github.com/coreos/go-systemd/v22 v22.5.0

proxy/server/target.go

@@ -668,7 +668,3 @@ func (u *unconnectedClientStream) SendMsg(interface{}) error {
 func (u *unconnectedClientStream) RecvMsg(interface{}) error {
 	return fmt.Errorf("%w: RecvMsg", errUnconnectedClient)
 }
-
-func init() {
-	rand.Seed(time.Now().UnixNano())
-}

services/process/server/process.go

@@ -230,7 +230,7 @@ func (s *server) GetStacks(ctx context.Context, req *pb.GetStacksRequest) (*pb.G
 		// New thread so append last entry and start over.
 		if fields[0] == "Thread" {
 			// Depending on wrapper/gdb this may have additional fields but we don't need them.
-			if len(fields) < 6 {
+			if len(fields) < 4 {
 				recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
 				return nil, status.Errorf(codes.Internal, "unparsable pstack output for new thread: %s", text)
 			}
@@ -244,13 +244,21 @@ func (s *server) GetStacks(ctx context.Context, req *pb.GetStacksRequest) (*pb.G
 				recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
 				return nil, status.Errorf(codes.Internal, "can't parse thread number: %s : %v", text, err)
 			}
-			if n, err := fmt.Sscanf(fields[3], "0x%x", &stack.ThreadId); n != 1 || err != nil {
-				recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
-				return nil, status.Errorf(codes.Internal, "can't parse thread id: %s : %v", text, err)
+			if fields[2] == "(Thread" && len(fields) >= 6 {
+				if n, err := fmt.Sscanf(fields[3], "0x%x", &stack.ThreadId); n != 1 || err != nil {
+					recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
+					return nil, status.Errorf(codes.Internal, "can't parse thread id: %s : %v", text, err)
+				}
+				if n, err := fmt.Sscanf(fields[5], "%d", &stack.Lwp); n != 1 || err != nil {
+					recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
+					return nil, status.Errorf(codes.Internal, "can't parse lwp: %s : %v", text, err)
+				}
 			}
-			if n, err := fmt.Sscanf(fields[5], "%d", &stack.Lwp); n != 1 || err != nil {
-				recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
-				return nil, status.Errorf(codes.Internal, "can't parse lwp: %s : %v", text, err)
+			if fields[2] == "(LWP" {
+				if n, err := fmt.Sscanf(fields[3], "%d", &stack.Lwp); n != 1 || err != nil {
+					recorder.CounterOrLog(ctx, processGetStacksFailureCounter, 1, attribute.String("reason", "parse_err"))
+					return nil, status.Errorf(codes.Internal, "can't parse lwp: %s : %v", text, err)
+				}
 			}
 			numEntries++
 			continue