Add a proto incompatibility check #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-srhodes
force-pushed
the
srhodes-buf-detection
branch
from
ffe5e1a to
8808324
Compare
sfc-gh-elinardi
approved these changes
Sep 26, 2023
sfc-gh-srhodes
force-pushed
the
srhodes-buf-detection
branch
from
a90b1fa to
7c206db
Compare
sfc-gh-srhodes
added a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a couple recent cases (#327, #281) where we've accidentally made backwards incompatible changes to our protobufs. This seems preventable by adding in automated checks.
I'm using https://github.com/bufbuild/buf-breaking-action and checking against main. I considered adding buf linting as well, but the linting detects tons of preexisting stylistic choices so it didn't seem worth doing so.