Skip to content

Commit

Permalink
Add a proto incompatibility check (#328)
Browse files Browse the repository at this point in the history
We've had a couple recent cases (#327, #281) where we've accidentally made backwards incompatible changes to our protobufs. This seems preventable by adding in automated checks.
 
I'm using https://github.com/bufbuild/buf-breaking-action and checking against main. I considered adding buf linting as well, but the linting detects tons of preexisting stylistic choices so it didn't seem worth doing so.
  • Loading branch information
sfc-gh-srhodes authored Sep 26, 2023
1 parent f6457a5 commit 1d2a2dd
Showing 1 changed file with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: golangci-lint
name: Lint
on:
pull_request:
permissions:
contents: read
jobs:
golangci:
name: lint
name: golangci lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -17,3 +17,12 @@ jobs:
with:
version: latest
args: --timeout=5m
buf-breaking:
name: incompatible proto changes
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: bufbuild/buf-setup-action@v1
- uses: bufbuild/buf-breaking-action@v1
with:
against: "https://github.com/Snowflake-Labs/sansshell.git#branch=main"

0 comments on commit 1d2a2dd

Please sign in to comment.