Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Transition from s4ext to json #2011

Merged
merged 7 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
name: Check description files
command: |
pip install joblib retry
python ./scripts/check_description_files.py --check-urls-reachable --check-dependencies . $(find . -maxdepth 1 -name "*.s4ext")
python ./scripts/check_description_files.py --check-dependencies . $(find . -maxdepth 1 -name "*.json")

workflows:
version: 2
Expand Down
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--
Thank you for contributing to 3D Slicer!
- To add a new extension with this pull request: Please keep content of "New extension" section and put an 'x' in the brackets for each todo item to indicate that you have accomplished that prerequisite.
- To update an existing extension with this pull request: Please delete all text in this template and just describe which extension is updated and optionally tell us in a sentence what has been changed. To make extension updates easier in the future you may consider replacing specific git hash in your s4ext file by a branch name (for example: `main` for Slicer Preview Releases; `(majorVersion).(minorVersion)` such as `4.10` for Slicer Stable Releases).
- To update an existing extension with this pull request: Please delete all text in this template and just describe which extension is updated and optionally tell us in a sentence what has been changed. To make extension updates easier in the future you may consider replacing specific git hash in your json file by a branch name (for example: `main` for Slicer Preview Releases; `(majorVersion).(minorVersion)` such as `5.6` for Slicer Stable Releases).
-->

# New extension
Expand All @@ -25,7 +25,7 @@ Thank you for contributing to 3D Slicer!
- [ ] Tutorial: step-by-step description of at least the most typical use case, include a few screenshots, provide download links to sample input data set
- [ ] Publication: link to publication and/or to PubMed reference (if available)
- [ ] License: We suggest you use a permissive license that includes patent and contribution clauses. This will help protect developers and ensure the code remains freely available. We suggest you use the [Slicer License](https://github.com/Slicer/Slicer/blob/main/License.txt) or the [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0). Always mention in your README file the license you have chosen. If you choose a different license, explain why to the extension maintainers. Depending on the license we may not be able to host your work. Read [here](https://opensource.guide/legal/#which-open-source-license-is-appropriate-for-my-project) to learn more about licenses.
- [ ] Content of submitted s4ext file is consistent with the top-level CMakeLists.txt file in the repository (description, URLs, dependencies, etc. are the same)
- [ ] Content of submitted json file is consistent with the top-level CMakeLists.txt file in the repository (dependencies, etc. are the same)
- Hide unused features in the repository to reduce noise/irrelevant information:
- [ ] Click `Settings` and in repository settings uncheck `Wiki`, `Projects`, and `Discussions` (if they are currently not used)
- [ ] Click the settings icon next to `About` in the top-right corner of the repository main page and uncheck `Releases` and `Packages` (if they are currently not used)
Expand Down
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,12 @@ repos:
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: "0.28.0"
hooks:
- id: check-jsonschema
files: ^[^/]*\.json$
args:
[
"--schemafile",
"https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json",
]
- id: check-dependabot
- id: check-github-workflows
8 changes: 8 additions & 0 deletions ABLTemporalBoneSegmentation.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": ["SlicerElastix"],
"build_subdirectory": "inner-build",
"category": "Otolaryngology",
"scm_revision": "master",
"scm_url": "https://github.com/Auditory-Biophysics-Lab/Slicer-ABLTemporalBoneSegmentation"
}
44 changes: 0 additions & 44 deletions ABLTemporalBoneSegmentation.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions AblationPlanner.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": ["ModelToModelDistance"],
"build_subdirectory": ".",
"category": "Quantification",
"scm_revision": "main",
"scm_url": "https://github.com/naterex23/SlicerAblationPlanner"
}
44 changes: 0 additions & 44 deletions AblationPlanner.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions AirwaySegmentation.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": [],
"build_subdirectory": ".",
"category": "Segmentation",
"scm_revision": "master",
"scm_url": "https://github.com/Slicer/SlicerAirwaySegmentation"
}
44 changes: 0 additions & 44 deletions AirwaySegmentation.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions AnglePlanesExtension.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": [],
"build_subdirectory": ".",
"category": "Shape Analysis",
"scm_revision": "master",
"scm_url": "https://github.com/DCBIA-OrthoLab/AnglePlanes-Extension.git"
}
44 changes: 0 additions & 44 deletions AnglePlanesExtension.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions AnomalousFiltersExtension.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": [],
"build_subdirectory": ".",
"category": "Filtering",
"scm_revision": "master",
"scm_url": "https://github.com/lassoan/AnomalousFiltersExtension.git"
}
44 changes: 0 additions & 44 deletions AnomalousFiltersExtension.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions ArduinoController.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": [],
"build_subdirectory": ".",
"category": "Developer Tools",
"scm_revision": "master",
"scm_url": "https://github.com/pzaffino/SlicerArduinoController.git"
}
42 changes: 0 additions & 42 deletions ArduinoController.s4ext

This file was deleted.

8 changes: 8 additions & 0 deletions AstmPhantomTest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#",
"build_dependencies": ["SlicerOpenIGTLink"],
"build_subdirectory": ".",
"category": "IGT",
"scm_revision": "master",
"scm_url": "https://github.com/Atracsys/SlicerAstmPhantomTest.git"
}
Loading