-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension management #813
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing activate If server extensions register listeners outside of activation, then we have no way of preventing them from registering if the user decided to disable it
This was referenced Jul 12, 2023
|
Putting this on pause from now until we have more use cases to learn from. |
vinistock
pushed a commit
that referenced
this pull request
Feb 28, 2024
…d-patch-9aea4da10c Bump the minor-and-patch group with 5 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #590
It will be good to allow clients to both display which Ruby LSP extensions are being used and also deactivate them if desired. Maybe an extension is failing and we want to disable it temporarily.
This PR adds a custom request that clients can use to discover which extensions have been registered and also starts accepting an initialization option with extension configuration, which clients can use to disable specific extensions.
Implementation
I split the implementation by commits.
activate
. We'll need to updateruby-lsp-rails
to match this, but I couldn't think of another way to de-register a listener that wouldn't involve messing up with the$LOAD_PATH
and$LOADED_FEATURES
I'd appreciate feedback on the approach.
Automated Tests
Added some tests.