Move listener registration to the extension activation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/move_registration_to_activate
branch
from
7bb0944 to
08c95f9
Compare
Morriar
approved these changes
Jul 12, 2023
| @@ -14,6 +14,9 @@ class Extension < ::RubyLsp::Extension | |||
|
|
|||
| sig { override.void } | |||
| def activate | |||
| ::RubyLsp::Requests::Hover.add_listener(RubyLsp::Rails::Hover) | |||
There was a problem hiding this comment.
Since we only register classes and not instances, I wonder if this could be moved in the Listener itself:
class RubyLsp::Rails::CodeLens < ::RubyLsp::Listener
listen_to ::RubyLsp::Requests::CodeLens
# ...
endThere was a problem hiding this comment.
That's an interesting approach, but it would lead to the same problem we're trying to avoid in this PR.
In order to disable an extension and avoid registering the listeners defined by it, we need the registration to happen in activate.
Basically, if the server extension is disabled, we just don't invoke activate. If the listener classes register themselves, then that will happen automatically when we require the Extension file and we'll have no way of stopping it.
|
Putting this on pause from now until we have more use cases to learn from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Shopify/ruby-lsp#813
We need to set a standard for registering feature enhancements always inside of
activateor else disabling extensions becomes significantly more difficult.This just moves our registrations there.