Declarative webhooks relative paths #3948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1669 tests passing in 775 suites. Report generated by 🧪jest coverage report action from 32b7e57 |
alexanderMontague
force-pushed
the
declarative_webhooks_relative_paths
branch
from
d56bef4 to
0296486
Compare
3 tasks
packages/app/src/cli/models/extensions/specifications/app_config_webhook_subscription.ts
Show resolved
Hide resolved
introduce local app config singleton, relative URIs on deploy simplify webhook app URIs to relative paths on link add manual mock for LocalAppConfiguration
alexanderMontague
force-pushed
the
declarative_webhooks_relative_paths
branch
from
0296486 to
6811acc
Compare
alexanderMontague
force-pushed
the
declarative_webhooks_relative_paths
branch
from
6811acc to
32b7e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes: https://github.com/Shopify/develop-app-management/issues/1599
Adds relative URIs to your app's URL to declarative webhooks
WHAT is this pull request doing?
fullAppConfigurationto various deploy and link locations in order to transform webhook subscriptions by checking theapplication_urlHow to test your changes?
deployandlinkwith relative subscription URIs, check the config to make sure it inherits the app url