-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support relative paths to application_url
for declarative webhooks
#3402
Conversation
caa3692
to
b9f0614
Compare
Coverage report
Test suite run success1584 tests passing in 738 suites. Report generated by 🧪jest coverage report action from d3daf82 |
b9f0614
to
9a97afa
Compare
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, but I'm not sure about the approach as I commented here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, but otherwise everything looks good to me!
|
||
// Then | ||
expect(result).toMatchObject({ | ||
webhooks: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we check that application_url
is what's to be expected as well?
packages/app/src/cli/models/extensions/specifications/app_config_webhook.test.ts
Show resolved
Hide resolved
e42c2e1
to
d3daf82
Compare
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
wip |
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
wip |
WHY are these changes introduced?
Closes https://github.com/Shopify/develop-app-management/issues/1599
WHAT is this pull request doing?
uri
s that are relative to theapplication_url
ex:
this is especially useful when using
app dev
as the app url changes every timethis also transforms the config on
app config link
, and we simplify like we do with thetopics
arrayex. if you have
and link, we will simplify the config to
application_url
cannot end in a forward slash so this protects against this on the app url sideHow to test your changes?
Checklist
dev
ordeploy
have been reflected in the internal flowchart.