Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBeta Bug Fix #124

Merged
merged 1 commit into from
Nov 15, 2024
Merged

DBeta Bug Fix #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions RecoTracker/LSTCore/src/alpaka/Quintuplet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,16 +1243,15 @@ namespace lst {
float sdIn_alpha_max = __H2F(segmentsInGPU.dPhiChangeMaxs[innerSegmentIndex]);
float sdOut_alpha = sdIn_alpha;

float sdOut_alphaOut = lst::phi_mpi_pi(acc,
lst::phi(acc,
mdsInGPU.anchorX[fourthMDIndex] - mdsInGPU.anchorX[thirdMDIndex],
mdsInGPU.anchorY[fourthMDIndex] - mdsInGPU.anchorY[thirdMDIndex]) -
mdsInGPU.anchorPhi[fourthMDIndex]);
Comment on lines -1246 to -1250
Copy link

@slava77 slava77 Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, this looks like a part from the barrel mixed up with the endcap logic below.

float sdOut_dPhiPos = lst::phi_mpi_pi(acc, mdsInGPU.anchorPhi[fourthMDIndex] - mdsInGPU.anchorPhi[thirdMDIndex]);

float sdOut_dPhiChange = __H2F(segmentsInGPU.dPhiChanges[outerSegmentIndex]);
float sdOut_dPhiChange_min = __H2F(segmentsInGPU.dPhiChangeMins[outerSegmentIndex]);
float sdOut_dPhiChange_max = __H2F(segmentsInGPU.dPhiChangeMaxs[outerSegmentIndex]);

float sdOut_alphaOut_min = lst::phi_mpi_pi(
acc, __H2F(segmentsInGPU.dPhiChangeMins[outerSegmentIndex]) - __H2F(segmentsInGPU.dPhiMins[outerSegmentIndex]));
float sdOut_alphaOut_max = lst::phi_mpi_pi(
acc, __H2F(segmentsInGPU.dPhiChangeMaxs[outerSegmentIndex]) - __H2F(segmentsInGPU.dPhiMaxs[outerSegmentIndex]));
float sdOut_alphaOutRHmin = lst::phi_mpi_pi(acc, sdOut_dPhiChange_min - sdOut_dPhiPos);
float sdOut_alphaOutRHmax = lst::phi_mpi_pi(acc, sdOut_dPhiChange_max - sdOut_dPhiPos);
float sdOut_alphaOut = lst::phi_mpi_pi(acc, sdOut_dPhiChange - sdOut_dPhiPos);

float tl_axis_x = mdsInGPU.anchorX[fourthMDIndex] - mdsInGPU.anchorX[firstMDIndex];
float tl_axis_y = mdsInGPU.anchorY[fourthMDIndex] - mdsInGPU.anchorY[firstMDIndex];
Expand All @@ -1276,8 +1275,8 @@ namespace lst {
betaInRHmax = betaIn - sdIn_alpha_max + sdIn_alpha;
}

betaOutRHmin = betaOut - sdOut_alphaOut_min + sdOut_alphaOut;
betaOutRHmax = betaOut - sdOut_alphaOut_max + sdOut_alphaOut;
betaOutRHmin = betaOut - sdOut_alphaOutRHmin + sdOut_alphaOut;
betaOutRHmax = betaOut - sdOut_alphaOutRHmax + sdOut_alphaOut;

float swapTemp;
if (alpaka::math::abs(acc, betaOutRHmin) > alpaka::math::abs(acc, betaOutRHmax)) {
Expand Down