Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBeta Bug Fix #124

Merged
merged 1 commit into from
Nov 15, 2024
Merged

DBeta Bug Fix #124

merged 1 commit into from
Nov 15, 2024

Conversation

GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented Nov 15, 2024 •
edited
Loading

Caused in part by code duplication of BBBB, BBEE, and EEEE functions. #96

Current Efficiency

This PR Efficiency

@GNiendorf
Copy link
Member Author

/run all

@github-actions GitHub Actions
Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     42.2    318.7    114.7     71.2     99.8    494.4    121.6    136.8    137.2      2.7    1539.2    1002.6+/- 264.0     421.6   explicit_cache[s=4] (target branch)
   avg     43.1    319.8    114.3     71.4    118.9    509.9    125.2    136.9    139.6      2.0    1581.2    1028.2+/- 278.8     431.1   explicit_cache[s=4] (this PR)

@GNiendorf GNiendorf changed the title DBeta Test DBeta Bug Fix Nov 15, 2024
@GNiendorf GNiendorf linked an issue Nov 15, 2024 that may be closed by this pull request
Second T5 Delta Beta Cut Efficiency Issues #123
Closed
@GNiendorf GNiendorf marked this pull request as ready for review November 15, 2024 18:25
@GNiendorf GNiendorf mentioned this pull request Nov 15, 2024
Closed
@GNiendorf GNiendorf mentioned this pull request Nov 15, 2024
Open
slava77
slava77 reviewed Nov 15, 2024
View reviewed changes
RecoTracker/LSTCore/src/alpaka/Quintuplet.h
Comment on lines -1246 to -1250
float sdOut_alphaOut = lst::phi_mpi_pi(acc,
lst::phi(acc,
mdsInGPU.anchorX[fourthMDIndex] - mdsInGPU.anchorX[thirdMDIndex],
mdsInGPU.anchorY[fourthMDIndex] - mdsInGPU.anchorY[thirdMDIndex]) -
mdsInGPU.anchorPhi[fourthMDIndex]);
Copy link

@slava77 slava77 Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, this looks like a part from the barrel mixed up with the endcap logic below.

@github-actions GitHub Actions
Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77 slava77 merged commit a34e2be into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel Nov 15, 2024
3 checks passed
This was referenced Nov 15, 2024
Closed
Open
@ariostas ariostas mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 approved these changes

Assignees

@slava77 slava77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second T5 Delta Beta Cut Efficiency Issues
2 participants
@GNiendorf @slava77