Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change password + refactor Field component #141

Merged

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Oct 21, 2023

Proposed changes

  • Adds change password button in account settings and endpoint.
  • Refactor Field component

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #61 and #132

@lennartkloock lennartkloock linked an issue Oct 21, 2023 that may be closed by this pull request
6 tasks
@lennartkloock lennartkloock mentioned this pull request Oct 21, 2023
6 tasks
@lennartkloock lennartkloock linked an issue Oct 28, 2023 that may be closed by this pull request
2 tasks
@lennartkloock lennartkloock changed the title feat: change password feat: change password + refactor Field component Oct 29, 2023
@lennartkloock lennartkloock force-pushed the lennartkloock/issue61 branch 2 times, most recently from 6d27aef to f4bd504 Compare October 29, 2023 23:08
@lennartkloock lennartkloock marked this pull request as ready for review October 29, 2023 23:08
@lennartkloock lennartkloock requested review from a team and TroyKomodo October 29, 2023 23:08
Copy link
Member

@TroyKomodo TroyKomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@lennartkloock lennartkloock force-pushed the lennartkloock/issue61 branch 2 times, most recently from 157b207 to dabf27a Compare November 4, 2023 19:31
Adds change password button in account settings and endpoint.
Refactors Field component.
@TroyKomodo TroyKomodo merged commit f1b8c44 into ScuffleCloud:feature/website Nov 4, 2023
1 of 2 checks passed
@lennartkloock lennartkloock deleted the lennartkloock/issue61 branch November 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: refactor auth dialog Basic User Settings
2 participants