-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change password + refactor Field component #141
Merged
TroyKomodo
merged 1 commit into
ScuffleCloud:feature/website
from
lennartkloock:lennartkloock/issue61
Nov 4, 2023
Merged
feat: change password + refactor Field component #141
TroyKomodo
merged 1 commit into
ScuffleCloud:feature/website
from
lennartkloock:lennartkloock/issue61
Nov 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
TroyKomodo
reviewed
Oct 22, 2023
2 tasks
lennartkloock
changed the title
feat: change password
feat: change password + refactor Field component
Oct 29, 2023
lennartkloock
force-pushed
the
lennartkloock/issue61
branch
2 times, most recently
from
October 29, 2023 23:08
6d27aef
to
f4bd504
Compare
TroyKomodo
reviewed
Nov 1, 2023
TroyKomodo
reviewed
Nov 1, 2023
TroyKomodo
reviewed
Nov 1, 2023
TroyKomodo
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
TroyKomodo
reviewed
Nov 1, 2023
TroyKomodo
reviewed
Nov 1, 2023
TroyKomodo
reviewed
Nov 4, 2023
lennartkloock
force-pushed
the
lennartkloock/issue61
branch
2 times, most recently
from
November 4, 2023 19:31
157b207
to
dabf27a
Compare
Adds change password button in account settings and endpoint. Refactors Field component.
lennartkloock
force-pushed
the
lennartkloock/issue61
branch
from
November 4, 2023 19:33
dabf27a
to
f1b8c44
Compare
TroyKomodo
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Field
componentTypes of changes
What types of changes does your code introduce to Scuffle?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Closes #61 and #132