Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: refactor auth dialog #132

Closed
2 tasks done
lennartkloock opened this issue Oct 11, 2023 · 3 comments · Fixed by #141
Closed
2 tasks done

[Feature]: refactor auth dialog #132

lennartkloock opened this issue Oct 11, 2023 · 3 comments · Fixed by #141
Assignees
@lennartkloock
Milestone
Initial Launch v1...

Comments

@lennartkloock
Copy link
Member

lennartkloock commented Oct 11, 2023 •
edited
Loading

Tell us about your Wish

The current auth dialog implementation is pretty bad.

Is your feature related to a bug

No response

Alternatives

No response

Additional Info

No response

Participation

  • I am willing to submit a pull request to implement this

Disclaimer

  • I agree
@lennartkloock lennartkloock self-assigned this Oct 11, 2023
@lennartkloock lennartkloock moved this to Todo in Scuffle Oct 11, 2023
@lennartkloock lennartkloock added this to the Initial Launch v1.0.0 milestone Oct 12, 2023
@TroyKomodo
Copy link
Member

TroyKomodo commented Oct 16, 2023 •
edited
Loading

Perhaps have the ability to generate a password? Since our passwords require quite a few strict requirements.

@TroyKomodo
Copy link
Member

Also, maybe allow for a magic email login link. Which will send the user an email which when they click the link, bypasses the password authentication.

@lennartkloock
Copy link
Member Author

Also, maybe allow for a magic email login link. Which will send the user an email which when they click the link, bypasses the password authentication.

This issue is just for frontend refactoring because the code is kinda weird. But you could maybe open a separate issue for this.

lennartkloock added a commit to lennartkloock/scuffle that referenced this issue Oct 28, 2023
@lennartkloock
feat: new field component
194938f 
This is much better than before.
Closes [Feature]: refactor auth dialog ScuffleCloud#132
@lennartkloock lennartkloock mentioned this issue Oct 28, 2023
Merged
9 tasks
@lennartkloock lennartkloock linked a pull request Oct 28, 2023 that will close this issue
feat: change password + refactor Field component #141
Merged
9 tasks
@lennartkloock lennartkloock moved this from Todo to In Progress in Scuffle Oct 29, 2023
@lennartkloock lennartkloock moved this from In Progress to Done in Scuffle Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lennartkloock lennartkloock

Labels
None yet
Projects
Scuffle
Archived in project
Milestone
Initial Launch v1.0.0
Development

Successfully merging a pull request may close this issue.

feat: change password + refactor Field component lennartkloock/scuffle
2 participants
@lennartkloock @TroyKomodo