Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

785 colour contrast readonly and placeholder text #850

Merged

Conversation

dhinrichs-scottlogic
Copy link
Contributor

@dhinrichs-scottlogic dhinrichs-scottlogic commented Feb 29, 2024

Description

Ensure all color contrast passes, including disabled buttons, readOnly fields (e.g. config inputs) and placeholder text (e.g. chat input). Closes #785

Screenshots

Image
Image
Image

Additional context

Colour contrast issues for placeholder text are easily missed by automated tools, but colour contrast ratios should still pass for placeholder text and inactive input text.

Notes

  • adjusted the --main-input-inactive-text-colour to pass but be less close to black
  • adjusted the --level-button-colour-disabled colour to provide better contrast (it technically passed before because the text is bold, but just nudging it to also pass 4.5:1).
  • Added placeholder pseudo selector to css to adjust textinput placeholder text colour

Checklist

Have you done the following?

  • Linked the relevant Issue
  • Added tests
  • Ensured the workflow steps are passing

@dhinrichs-scottlogic dhinrichs-scottlogic requested review from chriswilty and pmarsh-scottlogic and removed request for chriswilty February 29, 2024 14:54
Copy link
Contributor

@pmarsh-scottlogic pmarsh-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@dhinrichs-scottlogic dhinrichs-scottlogic merged commit 4958220 into dev Mar 1, 2024
2 checks passed
@dhinrichs-scottlogic dhinrichs-scottlogic deleted the 785-colour-contrast-readonly-and-placeholder-text branch March 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colour contrast readOnly and placeholder text
2 participants