Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour contrast readOnly and placeholder text #785

Closed
dhinrichs-scottlogic opened this issue Jan 19, 2024 · 0 comments · Fixed by #850
Closed

Colour contrast readOnly and placeholder text #785

dhinrichs-scottlogic opened this issue Jan 19, 2024 · 0 comments · Fixed by #850
Assignees
Labels
accessibility Addresses accessibility concerns frontend Requires work on the frontend should have triage New tickets to be checked by the maintainers

Comments

@dhinrichs-scottlogic
Copy link
Contributor

dhinrichs-scottlogic commented Jan 19, 2024

Feature Request

Description

Ensure all color contrast passes, including disabled buttons, readOnly fields (e.g. config inputs) and placeholder text (e.g. chat input)

  • adjusted the --main-input-inactive-text-colour to pass but be less close to black
  • adjusted the --level-button-colour-disabled colour to provide better contrast (it technically passed before because the text is bold, but just nudging it to also pass 4.5:1).
  • Added placeholder pseudo selector to css to adjust textinput placeholder text colour

Screenshots

Image
Image
Image

Additional context

Colour contrast issues for placeholder text are easily missed by automated tools, but colour contrast ratios should still pass for placeholder text and inactive input text.

Acceptance criteria

GIVEN text/number inputs and buttons
WHEN they are disabled, readonly or have placeholder text
THEN the text to background contrast ratio is at least 4.5:1

@dhinrichs-scottlogic dhinrichs-scottlogic added accessibility Addresses accessibility concerns frontend Requires work on the frontend should have triage New tickets to be checked by the maintainers labels Jan 19, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic changed the title [a11y] colour contrast readOnly and placeholder text Colour contrast readOnly and placeholder text Jan 19, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic self-assigned this Feb 29, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic linked a pull request Feb 29, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Addresses accessibility concerns frontend Requires work on the frontend should have triage New tickets to be checked by the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant