Dockerfile: use unprivileged nginx

[cfelder]

This allows running this container w/ arbitrary uid support

Description

Short description of the pull request

Motivation

running SciCat in an OpenShift environment w/ arbitrary uids

Fixes:

• nginx unprivileged

Changes:

• unprivileged port 8080

Summary by Sourcery

Use the unprivileged nginx image to support running the container with arbitrary user IDs, and update the exposed port to 8080.

Build:

• Switch to using the nginxinc/nginx-unprivileged base image in the Dockerfile.

CI:

• Update the docker-compose configuration to expose port 8080 instead of 80.

[sourcery-ai]

Hey @cfelder - I've reviewed your changes - here's some feedback:

Overall Comments:

• Could you explain how the default nginx configuration from nginx-unprivileged meets your application's needs? The removal of the custom nginx.conf might affect routing or other specific settings.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[bpedersen2]

the e2e tests require the nginx.conf file, don't delete it

[bpedersen2]

the e2e tests require the nginx.conf file, don't delete it

[bpedersen2]

this cleanup line should probably also stay

[bpedersen2]

The mapping change in docker-compose was correct. But preserve the nginx.conf file and the cleanups in the docker file.

Note that this Dockerfile not meant for direct production use, as it contains lots of default passwords.

[bpedersen2]

You missed the correct e2e docker compose file:
github uses CI/ESS/e2e/docker-compose.e2e.yaml

note the ESS in path.

Corresponding changes for the backend tests are probably needed.

[bpedersen2]

needs a rebase to get the restructred e2e tests ( the docker composefiel touched is then correct

[bpedersen2]

Should be finalized in of sciat online meeting .

( i added this review to block merging until then, otherwise the code changes are OK for me.)

[bpedersen2]

I added a few more reviewers, as this also requires all downstream consumers of the image to adjust the port mapping.

Probably needs updates in the docs and in scicatlive.

BE e2e tests should work automatically, as the frontend container only exposes one port, so that traefik will pick it up correctly (https://doc.traefik.io/traefik/providers/docker/#port-detection).

[bpedersen2]

Probably needs updates in the docs and in scicatlive.

Scicatlive is also fine as it also uses traefik