fixes #1553 #1554
Open
fixes #1553 #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bpedersen2
requested changes
Aug 19, 2024
| access_log /var/log/nginx/access.log main; | ||
|
|
||
|
|
||
| client_body_temp_path /tmp/client_temp; |
There was a problem hiding this comment.
I would prefer to keep the original locations ( var/cache/nginx/... ) and instead fix permissions in the image build.
There was a problem hiding this comment.
That's also an option. It was more along the line of "just log to stdout / stderr if it's running in a container".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in the issue, the user does not need to be
root, even for nginx.This PR sets the
nginx.confthe way the official docs describe what is needed to run as a rootless user.