Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session name for bookmarks #14242

Merged
merged 1 commit into from
Mar 11, 2024
Merged

session name for bookmarks #14242

merged 1 commit into from
Mar 11, 2024

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Mar 1, 2024

Problem Statement

name.lower wasn't always equal with session name, also removed some dead code and unused params

Solution

making the session name explicit in constants

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 1, 2024
@pondrejk pondrejk self-assigned this Mar 1, 2024
@pondrejk pondrejk requested review from a team as code owners March 1, 2024 15:39
@pondrejk
Copy link
Contributor Author

pondrejk commented Mar 1, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public

@pondrejk pondrejk mentioned this pull request Mar 1, 2024
Merged
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5920
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public --external-logging
Test Result : = 8 failed, 30 passed, 156 deselected, 102 warnings, 1 error in 3791.45s (1:03:11) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 1, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Mar 4, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5922
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public --external-logging
Test Result : = 6 failed, 30 passed, 1 skipped, 156 deselected, 99 warnings, 2 errors in 4429.18s (1:13:49) =

lhellebr
lhellebr approved these changes Mar 5, 2024
View reviewed changes
robottelo/constants/__init__.py
'controller': 'katello_docker_tags',
'session_name': 'containerimagetag',
},
{'name': 'Host', 'controller': 'hosts', 'setup': entities.Host, 'session_name': 'host_new'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the example where session_name != name.lower()

@pondrejk
Copy link
Contributor Author

pondrejk commented Mar 6, 2024

the remaining failures are not due to the original problem, some more work on the airgun side is needed for those

@pondrejk pondrejk enabled auto-merge (squash) March 6, 2024 13:09
@pondrejk pondrejk disabled auto-merge March 6, 2024 13:09
vsedmik
vsedmik approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs rebase.
Also the CI/CQ has been fixed if I am not quite mistaken.

@pondrejk pondrejk merged commit 2c2de86 into SatelliteQE:master Mar 11, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@pondrejk @web-flow
session name for bookmarks (#14242)
f91d9f2 
(cherry picked from commit 2c2de86)
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@pondrejk @web-flow
session name for bookmarks (#14242)
6563af7 
(cherry picked from commit 2c2de86)
This was referenced Mar 11, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@pondrejk @web-flow
session name for bookmarks (#14242)
6e05d6c 
(cherry picked from commit 2c2de86)
@Satellite-QE Satellite-QE mentioned this pull request Mar 11, 2024
Merged
pondrejk added a commit that referenced this pull request Mar 11, 2024
@Satellite-QE @pondrejk
[6.13.z] session name for bookmarks (#14332)
91e142b 
session name for bookmarks (#14242)

(cherry picked from commit 2c2de86)

Co-authored-by: Peter Ondrejka <[email protected]>
pondrejk added a commit that referenced this pull request Mar 11, 2024
@Satellite-QE @pondrejk
[6.14.z] session name for bookmarks (#14333)
d2a8ef1 
session name for bookmarks (#14242)

(cherry picked from commit 2c2de86)

Co-authored-by: Peter Ondrejka <[email protected]>
pondrejk added a commit that referenced this pull request Mar 11, 2024
@Satellite-QE @pondrejk
[6.15.z] session name for bookmarks (#14334)
0e6dee6 
session name for bookmarks (#14242)

(cherry picked from commit 2c2de86)

Co-authored-by: Peter Ondrejka <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
session name for bookmarks (SatelliteQE#14242)
e5cac5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pondrejk pondrejk

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @lhellebr @vsedmik