Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] session name for bookmarks #14333

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14242

Problem Statement

name.lower wasn't always equal with session name, also removed some dead code and unused params

Solution

making the session name explicit in constants

(cherry picked from commit 2c2de86)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 11, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 11, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6011
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_positive_create_bookmark_public --external-logging
Test Result : = 6 failed, 30 passed, 1 skipped, 156 deselected, 89 warnings, 2 errors in 3864.20s (1:04:24) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 11, 2024
@pondrejk
Copy link
Contributor

the 6 remaining failures are not due to the original problem, some more work on the airgun side is needed for those

@pondrejk pondrejk merged commit d2a8ef1 into 6.14.z Mar 11, 2024
23 of 26 checks passed
@pondrejk pondrejk deleted the cherry-pick-6.14.z-2c2de86bc782c60bf4fc2c291717543252f088e1 branch March 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants