refactor : Define a constant instead of duplicating this literal #PAR…

…-383
SWM-KAWAI-MANS · Oct 14, 2023 · 539ed46 · 539ed46
1 parent 5219261
commit 539ed46
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/...ain/java/online/partyrun/partyrunapplication/core/data/repository/ResultRepositoryImpl.kt b/...ain/java/online/partyrun/partyrunapplication/core/data/repository/ResultRepositoryImpl.kt
@@ -31,6 +31,9 @@ class ResultRepositoryImpl @Inject constructor(
     private val battlePreferencesDataSource: BattlePreferencesDataSource,
     private val singlePreferencesDataSource: SinglePreferencesDataSource
 ) : ResultRepository {
+    companion object {
+        const val UNKNOWN_ERROR = "Unknown Error"
+    }
 
     override suspend fun getBattleResults(): Flow<Result<BattleResult>> {
         return apiRequestFlow {
@@ -59,7 +62,7 @@ class ResultRepositoryImpl @Inject constructor(
             singleRunningHistoryDao.insertAllSingleRunningHistory(result.toEntity())
             emit(Result.Success(Unit))
         }.onException { e ->
-            emit(Result.Failure(e.message ?: "UnKnown Error", -1))
+            emit(Result.Failure(e.message ?: UNKNOWN_ERROR, -1))
         }
     }
 
@@ -70,7 +73,7 @@ class ResultRepositoryImpl @Inject constructor(
             battleRunningHistoryDao.insertAllBattleRunningHistory(result.toEntity())
             emit(Result.Success(Unit))
         }.onException { e ->
-            emit(Result.Failure(e.message ?: "UnKnown Error", -1))
+            emit(Result.Failure(e.message ?: UNKNOWN_ERROR, -1))
         }
     }
 
@@ -80,7 +83,7 @@ class ResultRepositoryImpl @Inject constructor(
                 try {
                     Result.Success(SingleRunningHistory(entityList.map { it.toDomainModel() }))
                 } catch (e: Exception) {
-                    Result.Failure(e.message ?: "Unknown Error", -1)
+                    Result.Failure(e.message ?: UNKNOWN_ERROR, -1)
                 }
             }
     }
@@ -91,7 +94,7 @@ class ResultRepositoryImpl @Inject constructor(
                 try {
                     Result.Success(BattleRunningHistory(entityList.map { it.toDomainModel() }))
                 } catch (e: Exception) {
-                    Result.Failure(e.message ?: "Unknown Error", -1)
+                    Result.Failure(e.message ?: UNKNOWN_ERROR, -1)
                 }
             }
     }
@@ -103,7 +106,7 @@ class ResultRepositoryImpl @Inject constructor(
             battleRunningHistoryDao.deleteAllBattleRunningHistories()
             emit(Result.Success(Unit))
         } catch (e: Exception) {
-            emit(Result.Failure(e.message ?: "Unknown Error", -1))
+            emit(Result.Failure(e.message ?: UNKNOWN_ERROR, -1))
         }
     }