refactor : RunningHistoryDetailResponse 중복 코드 함수 분리 #PAR-383

SWM-KAWAI-MANS · Oct 14, 2023 · 5219261 · 5219261
1 parent 4a7e218
commit 5219261
Showing 1 changed file with 18 additions and 22 deletions.
diff --git a/.../partyrun/partyrunapplication/core/network/model/response/RunningHistoryDetailResponse.kt b/.../partyrun/partyrunapplication/core/network/model/response/RunningHistoryDetailResponse.kt
@@ -22,50 +22,46 @@ data class RunningHistoryDetailResponse(
     val distance: Double?
 )
 
-fun RunningHistoryDetailResponse.toDomainModel(): RunningHistoryDetail {
-    val parsedDate = startTime?.let {
+fun RunningHistoryDetailResponse.getFormattedRunningTime(): String {
+    return this.runningTime?.toElapsedTimeString() ?: "00:00:00"
+}
+
+fun RunningHistoryDetailResponse.getParsedDate(): LocalDateTime? {
+    return startTime?.let {
         LocalDateTime.parse(
             it,
             DateTimeUtils.localDateTimeFormatter
         )
     }
+}
+
+fun RunningHistoryDetailResponse.getFormattedDate(): String {
+    return getParsedDate()?.let { formatDate(it) } ?: ""
+}
 
+fun RunningHistoryDetailResponse.toDomainModel(): RunningHistoryDetail {
     return RunningHistoryDetail(
         id = this.id ?: "",
-        date = parsedDate?.let { formatDate(it) } ?: "",
-        runningTime = this.runningTime?.toElapsedTimeString() ?: "00:00:00",
+        date = getFormattedDate(),
+        runningTime = getFormattedRunningTime(),
         distanceFormatted = formatDistanceWithComma(this.distance?.toInt() ?: 0)
     )
 }
 
 fun RunningHistoryDetailResponse.toSingleRunningHistoryEntity(): SingleRunningHistoryEntity {
-    val parsedDate = startTime?.let {
-        LocalDateTime.parse(
-            it,
-            DateTimeUtils.localDateTimeFormatter
-        )
-    }
-
     return SingleRunningHistoryEntity(
         id = this.id ?: "",
-        date = parsedDate?.let { formatDate(it) } ?: "",
-        runningTime = this.runningTime?.toElapsedTimeString() ?: "00:00:00",
+        date = getFormattedDate(),
+        runningTime = getFormattedRunningTime(),
         distanceFormatted = formatDistanceWithComma(this.distance?.toInt() ?: 0)
     )
 }
 
 fun RunningHistoryDetailResponse.toBattleRunningHistoryEntity(): BattleRunningHistoryEntity {
-    val parsedDate = startTime?.let {
-        LocalDateTime.parse(
-            it,
-            DateTimeUtils.localDateTimeFormatter
-        )
-    }
-
     return BattleRunningHistoryEntity(
         id = this.id ?: "",
-        date = parsedDate?.let { formatDate(it) } ?: "",
-        runningTime = this.runningTime?.toElapsedTimeString() ?: "00:00:00",
+        date = getFormattedDate(),
+        runningTime = getFormattedRunningTime(),
         distanceFormatted = formatDistanceWithComma(this.distance?.toInt() ?: 0)
     )
 }