SUM-47 Theme & Style local footer #1
Conversation
pookmish
force-pushed
the
feature/SUM-47--themeFooter
branch
from
8325df5 to
610f2ca
Compare
| {suLocalFootSocial && | ||
| <ul className="list-unstyled flex gap-2"> | ||
| <ul className="rs-mt-4 list-unstyled flex gap-11 items-center children:mb-0"> |
There was a problem hiding this comment.
Why children:mb-0 instead of mb-0 on the <li> element? I'm not asking for any changes, just curious of your choice here.
There was a problem hiding this comment.
Ah, this was user error 😄 I was moving some things around and added seperate <li> item so I added children:mb-0 so that all children are targeted. I eventually removed it and forgot to rework the classes. In this case, we can definitely further specify and add className="children:mb-0" to the <li>
There was a problem hiding this comment.
This comment not related to whether we use children:mb-0 on ul or mb-0 on li, but *: has officially replaced children: - it's in Tailwind core now 😄 @rebeccahongsf
|
Also, FYI, i rebased with |
src/components/elements/button.tsx
Outdated
| @@ -41,7 +42,7 @@ type Props = HtmlHTMLAttributes<HTMLAnchorElement | HTMLButtonElement> & { | |||
| * Disabled button element. | |||
| */ | |||
| disabled?: boolean | |||
| } | |||
| }; | |||
|
|
|||
| export const Button = ({ | |||
There was a problem hiding this comment.
Hover/focus colors need fixed. the text color is black on the red background. it won't pass a11y
…n, adjust footer styles
pookmish
force-pushed
the
feature/SUM-47--themeFooter
branch
from
5f45c5b to
e235df6
Compare
pookmish
changed the title
READY FOR REVIEW
Summary
Review By (Date)
Urgency
Review Tasks
Setup tasks and/or behavior to test
yarn devSite Configuration Sync
Front End Validation
Associated Issues and/or People