-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUM-46 Theme & Style alert message #2
Conversation
@rebeccahongsf Will this repo get preview URLs instead of having to review locally? 🤔 |
{suGlobalMsgHeader && <H2>{suGlobalMsgHeader}</H2>} | ||
|
||
<Wysiwyg html={suGlobalMsgMessage?.processed}/> | ||
<div className='bg-fog-light'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this? it puts a background behind the alert that is different than the background behind the menu/lockup area. If so, use double quotes.
@yvonnetangsu yeah, we'll have preview URLs once we get the client to provide billing for the Vercel environment. We only get 7 days for free since the repo is in an org space. They force us into the "Pro" plan. |
Fantastic! Thanks @pookmish 😄 I won't be reviewing every PR, but I was asked to do periodic front end QAs (like once a month or so). |
READY FOR REVIEW
Summary
Review By (Date)
Urgency
Review Tasks
Setup tasks and/or behavior to test
yarn dev
Note:
bg-fog-light
will match the header once the heading work has been implemented.Site Configuration Sync
Front End Validation
Associated Issues and/or People