Code

Internal/quantify/random access#615

Code

Merged

SSoelvsten merged 55 commits intomainSSoelvsten/adiar:mainfrom internal/quantify/random-accessSSoelvsten/adiar:internal/quantify/random-accessCopy head branch name to clipboardFeb 26, 2024

+8,930-4,342

Commits

Commits on Feb 15, 2024

• Prepare Quantification unit testing suite for Random Access optimisation

  SSoelvsten

  committed
  ddb92fd

• Remove resolved TODO comment

  SSoelvsten

  committed
  d292dbd

Commits on Feb 16, 2024

• Simplify and fix bug in threshold for random access

  Show description for 0417427
  SSoelvsten

  committed
  0417427

• Fix Naming Scheme in Quantification

  Show description for 8aefffd
  SSoelvsten

  committed
  8aefffd

• Add missing documentation comments in Quantification

  SSoelvsten

  committed
  97bc9e8

• Differentiate '__quantify<...>' algorithms with a secondary priority queue

  SSoelvsten

  committed
  cd5e8fd

Commits on Feb 19, 2024

• Widen documentation in <adiar/internal/util.h> to 100

  SSoelvsten

  committed
  d4f673b

• Add invariant of not popping request to simplify later loops

  Show description for 1a0b0fa
  SSoelvsten

  committed
  1a0b0fa

• Remove never-true compile-time conditional

  SSoelvsten

  committed
  90359d6

• Simplify Prod2 logic with a more generalised Handler

  SSoelvsten

  committed
  dd7ccd9

• Generalise handlers in Prod2 logic

  SSoelvsten

  committed
  158c5f4

• Add 'has_top()' as a common interface for priority queues (levelized or not)

  SSoelvsten

  committed
  6ba079e

• Generalise logic and types of '__prod2_recurse_out'

  SSoelvsten

  committed
  8368dc1

• Simplify and Merge 'recurse_in' and 'recurse_out' functions for Prod2

  SSoelvsten

  committed
  b89a2e6

• Shortcut irrelevant conditional for 'bdd_apply' at compile-time

  SSoelvsten

  committed
  43ef19a

• Add abstract at the top of Quantification algorithm

  SSoelvsten

  committed
  5b8bbef

• Rename 'forward_request' to 'recurse_out' to match Prod2

  SSoelvsten

  committed
  af12182

• Move general 'request_foreach' into 'util.h'

  SSoelvsten

  committed
  a255738

• Add 'has_top' to Nested Sweeping's priority queue decorators

  SSoelvsten

  committed
  2545b0f

• Use 'request_foreach' in Quantify algorithm

  SSoelvsten

  committed
  a02d1c5

• Remove unsolveable TODO

  Show description for df56c7c
  SSoelvsten

  committed
  df56c7c

• Rename '__quantify' for two priority queues appropriately

  SSoelvsten

  committed
  03dcad1

• Skip first level in priority queue, if root is quantified

  SSoelvsten

  committed
  6728a8f

• Remove magic constant in default value for statistics struct

  SSoelvsten

  committed
  3d54874

• Add random access to Quantification (WIP)

  SSoelvsten

  committed
  82d9470

• Merge quantification of f and (f,g) cases

  SSoelvsten

  committed
  55dd610

• Clean up of unit tests, e.g. make inputs canonical

  SSoelvsten

  committed
  23d80f3

Commits on Feb 20, 2024

• Remove resolved TODO

  SSoelvsten

  committed
  e243988

• Relax random-access criteria from 'canonical' to 'indexable'

  SSoelvsten

  committed
  038d49d

• Use Random Access on Nested Inner Sweeps

  SSoelvsten

  committed
  053ffa6

Commits on Feb 22, 2024

• Add 'width' meta data to 'levelized_file<arc>'

  SSoelvsten

  committed
  59aef3a

• Use type from '__bdd' rather than hardcoding it

  SSoelvsten

  committed
  93c3bd5

• Expand column width to 100

  SSoelvsten

  committed
  d6c9643

• Remove 'Reverse' template parameter

  Show description for 98976a7
  SSoelvsten

  committed
  98976a7

• Clean up 'node_arc_stream'

  SSoelvsten

  committed
  1661361

• Fix 'node_arc_stream::peek()' gets stuck peeking the same arc twice

  SSoelvsten

  committed
  06c4fc6

• Make '_root' variable const

  SSoelvsten

  committed
  f31a2ec

• Slightly generalise 'node_random_access' into a common 'levelized_random_access'

  SSoelvsten

  committed
  5179bbe

• Move logic for random access to 'levelized_file<node>' into its own class

  SSoelvsten

  committed
  376a786

• Move 'levelized_random_access' class fully to its own file

  SSoelvsten

  committed
  0d3c0c6

• Add levelized (top-down) random access to untransposed unreduced decision diagrams

  SSoelvsten

  committed
  31611cd

Commits on Feb 23, 2024

• Remove resolved TODO

  SSoelvsten

  committed
  f8ce2fa

• Reformat and update comments for Levelized Priority Queue

  SSoelvsten

  committed
  569c083

• Add additional assertions for debugging purposes

  SSoelvsten

  committed
  531e4e8

• Update comments in Quanfify

  SSoelvsten

  committed
  1301067

• Add missing accounting for style of sweep during repeated transposition

  SSoelvsten

  committed
  e13c8e5

• Add random-access to Repeated Transposition sweeps

  SSoelvsten

  committed
  43db66e

• Fix formatting of latest changes

  SSoelvsten

  committed
  bdb937f

• Improve comments and structure of '__quantify_resolve_request'

  SSoelvsten

  committed
  f8f3a91

• Add missing unit tests for 'bdd_forall(f, x)' with random access

  SSoelvsten

  committed
  aa82631

• Add tests to cover Nested Sweeping using a secondary priority queue

  SSoelvsten

  committed
  6098e01

• Add tests to cover Repeated Transposition using a secondary priority queue

  SSoelvsten

  committed
  110e4cc

Commits on Feb 26, 2024

• Expand comments to column 100

  SSoelvsten

  committed
  1af9709

• Cover 'partial quantification' leaving a node for both algorithmic variants

  SSoelvsten

  committed
  32c274b

• Format latest changes to 'test/adiar/bdd/quantify'

  SSoelvsten

  committed
  c8883dd