Internal/quantify/random access #615

SSoelvsten · 2024-02-23T09:20:53Z

Closes #488 to then close #483 .

Prior to this, one could end in the random-access case with two non-canonical diagrams

Some parts of the naming scheme, e.g. 'request_t' are still broken. To fix these, we need to also touch the Nested Sweeping framework.

…queue

This allows us to split the loops in two and thereby hopefully drastically improve the code quality

…or not)

As far as I can tell, the canonicity of 'resolve_request' already takes care of this case?

github-actions · 2024-02-23T09:21:29Z

Cppcheck

nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

codecov · 2024-02-23T09:52:47Z

Codecov Report

Attention: Patch coverage is 98.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.224%. Comparing base (fba2df5) to head (c8883dd).

Files	Patch %	Lines
src/adiar/internal/algorithms/quantify.h	98.299%	5 Missing ⚠️
src/adiar/internal/algorithms/nested_sweeping.h	96.667%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main      #615       +/-   ##
=============================================
+ Coverage   97.159%   97.224%   +0.066%     
=============================================
  Files           88        90        +2     
  Lines         6124      6341      +217     
=============================================
+ Hits          5950      6165      +215     
- Misses         174       176        +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SSoelvsten · 2024-02-23T09:58:00Z

The missing coverage is due to

External Priority Queue cases ( unsolveable(ish) )
Secondary Priority Queue case for Repeated Transposition
Secondary Priority Queue case for entry point to Nested Sweeping
PQ variant leaving a node behind during repeated transposition.

Furthermore:

There are no unit tests to cover bdd_forall(f, int)

github-actions · 2024-02-23T10:11:52Z

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/quantify/random-access' is a change in performance of -0.51% (stdev: 1.30%).

...	origin/main	origin/internal/quantify/random-access
Mean	112564.33	113137.33
Standard Deviation	1468.94	220.10

Number of samples: 3

github-actions · 2024-02-23T10:13:23Z

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/quantify/random-access' is a change in performance of 24.05% (stdev: 1.23%).

...	origin/main	origin/internal/quantify/random-access
Mean	9945.60	7553.40
Standard Deviation	122.29	40.48

Number of samples: 5

github-actions · 2024-02-23T10:13:43Z

🟢 Regression Test (Picotrav 'adder')

'origin/internal/quantify/random-access' is a change in performance of 0.52% (stdev: 9.07%).

...	origin/main	origin/internal/quantify/random-access
Mean	9649.00	9599.00
Standard Deviation	872.47	870.73

Number of samples: 10

github-actions · 2024-02-23T10:14:35Z

🟡 Regression Test (Picotrav 'arbiter')

'origin/internal/quantify/random-access' is a change in performance of -0.76% (stdev: 1.27%).

...	origin/main	origin/internal/quantify/random-access
Mean	62574.00	63050.25
Standard Deviation	792.03	488.66

Number of samples: 4

github-actions · 2024-02-23T10:21:56Z

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/random-access' is a change in performance of 28.61% (stdev: 4.52%).

...	origin/main	origin/internal/quantify/random-access
Mean	31274.00	22326.00
Standard Deviation	1414.00	14.88

Number of samples: 4

github-actions · 2024-02-23T10:27:34Z

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/random-access' is a change in performance of 12.73% (stdev: 1.39%).

...	origin/main	origin/internal/quantify/random-access
Mean	29051.00	25354.25
Standard Deviation	402.84	316.02

Number of samples: 4

…queue

github-actions · 2024-02-23T11:05:43Z

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/random-access' is a change in performance of 38.08% (stdev: 5.75%).

...	origin/main	origin/internal/quantify/random-access
Mean	44209.10	27375.70
Standard Deviation	2541.89	133.48

Number of samples: 10

…riants

SSoelvsten added 30 commits February 15, 2024 11:44

Prepare Quantification unit testing suite for Random Access optimisation

ddb92fd

Remove resolved TODO comment

d292dbd

Simplify and fix bug in threshold for random access

0417427

Prior to this, one could end in the random-access case with two non-canonical diagrams

Fix Naming Scheme in Quantification

8aefffd

Some parts of the naming scheme, e.g. 'request_t' are still broken. To fix these, we need to also touch the Nested Sweeping framework.

Add missing documentation comments in Quantification

97bc9e8

Differentiate '__quantify<...>' algorithms with a secondary priority …

cd5e8fd

…queue

Widen documentation in <adiar/internal/util.h> to 100

d4f673b

Add invariant of not popping request to simplify later loops

1a0b0fa

This allows us to split the loops in two and thereby hopefully drastically improve the code quality

Remove never-true compile-time conditional

90359d6

Simplify Prod2 logic with a more generalised Handler

dd7ccd9

Generalise handlers in Prod2 logic

158c5f4

Add 'has_top()' as a common interface for priority queues (levelized …

6ba079e

…or not)

Generalise logic and types of '__prod2_recurse_out'

8368dc1

Simplify and Merge 'recurse_in' and 'recurse_out' functions for Prod2

b89a2e6

Shortcut irrelevant conditional for 'bdd_apply' at compile-time

43ef19a

Add abstract at the top of Quantification algorithm

5b8bbef

Rename 'forward_request' to 'recurse_out' to match Prod2

af12182

Move general 'request_foreach' into 'util.h'

a255738

Add 'has_top' to Nested Sweeping's priority queue decorators

2545b0f

Use 'request_foreach' in Quantify algorithm

a02d1c5

Remove unsolveable TODO

df56c7c

As far as I can tell, the canonicity of 'resolve_request' already takes care of this case?

Rename '__quantify' for two priority queues appropriately

03dcad1

Skip first level in priority queue, if root is quantified

6728a8f

Remove magic constant in default value for statistics struct

3d54874

Add random access to Quantification (WIP)

82d9470

Merge quantification of f and (f,g) cases

55dd610

Clean up of unit tests, e.g. make inputs canonical

23d80f3

Remove resolved TODO

e243988

Relax random-access criteria from 'canonical' to 'indexable'

038d49d

Use Random Access on Nested Inner Sweeps

053ffa6

SSoelvsten added 6 commits February 23, 2024 09:18

Remove resolved TODO

f8ce2fa

Reformat and update comments for Levelized Priority Queue

569c083

Add additional assertions for debugging purposes

531e4e8

Update comments in Quanfify

1301067

Add missing accounting for style of sweep during repeated transposition

e13c8e5

Add random-access to Repeated Transposition sweeps

43db66e

SSoelvsten added the ✨ optimisation It's all about speed / space label Feb 23, 2024

SSoelvsten added this to the v2.0 : Random-Access for Narrow Decision Diagrams milestone Feb 23, 2024

SSoelvsten self-assigned this Feb 23, 2024

Fix formatting of latest changes

bdb937f

SSoelvsten added 4 commits February 23, 2024 11:35

Improve comments and structure of '__quantify_resolve_request'

f8f3a91

Add missing unit tests for 'bdd_forall(f, x)' with random access

aa82631

Add tests to cover Nested Sweeping using a secondary priority queue

6098e01

Add tests to cover Repeated Transposition using a secondary priority …

110e4cc

…queue

SSoelvsten added 2 commits February 26, 2024 10:07

Expand comments to column 100

1af9709

Cover 'partial quantification' leaving a node for both algorithmic va…

32c274b

…riants

SSoelvsten force-pushed the internal/quantify/random-access branch from 10417f9 to 32c274b Compare February 26, 2024 09:57

Format latest changes to 'test/adiar/bdd/quantify'

c8883dd

SSoelvsten merged commit acd18b0 into main Feb 26, 2024
53 of 54 checks passed

SSoelvsten deleted the internal/quantify/random-access branch March 7, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal/quantify/random access #615

Internal/quantify/random access #615

SSoelvsten commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

codecov bot commented Feb 23, 2024 •

edited

Loading

SSoelvsten commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

Internal/quantify/random access #615

Internal/quantify/random access #615

Conversation

SSoelvsten commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

Cppcheck

codecov bot commented Feb 23, 2024 • edited Loading

Codecov Report

SSoelvsten commented Feb 23, 2024 • edited Loading

github-actions bot commented Feb 23, 2024 • edited Loading

🟡 Regression Test (Picotrav 'mem_ctrl')

github-actions bot commented Feb 23, 2024 • edited Loading

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

github-actions bot commented Feb 23, 2024 • edited Loading

🟢 Regression Test (Picotrav 'adder')

github-actions bot commented Feb 23, 2024 • edited Loading

🟡 Regression Test (Picotrav 'arbiter')

github-actions bot commented Feb 23, 2024 • edited Loading

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

github-actions bot commented Feb 23, 2024 • edited Loading

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

github-actions bot commented Feb 23, 2024 • edited Loading

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

codecov bot commented Feb 23, 2024 •

edited

Loading

SSoelvsten commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading

github-actions bot commented Feb 23, 2024 •

edited

Loading