Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESPONDER: use proper context for getDomains() #7320

Closed

Conversation

alexey-tikhonov
Copy link
Member

Request was created on a long term responder context, but a callback for this request tries to access memory that is allocated on a short term client context. So if client disconnects before request is completed, then callback dereferences already freed memory.

Resolves: #7319

Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Just please fix the commit message s/user/use, I suppose.

@alexey-tikhonov alexey-tikhonov changed the title RESPONDER: user proper context for getDomains() RESPONDER: use proper context for getDomains() May 2, 2024
Request was created on a long term responder context, but a callback
for this request tries to access memory that is allocated on a short
term client context. So if client disconnects before request is
completed, then callback dereferences already freed memory.

Resolves: SSSD#7319
@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented May 2, 2024

Ack. Just please fix the commit message s/user/use, I suppose.

Done (and rebased).

@alexey-tikhonov alexey-tikhonov requested a review from pbrezina May 2, 2024 09:21
@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7320

  • master
    • dc637c9 - RESPONDER: use proper context for getDomains()
  • sssd-2-9
    • b0fda92 - RESPONDER: use proper context for getDomains()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAC and PAM responders can crash if backend takes too long time to process getDomains()
3 participants