Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAC and PAM responders can crash if backend takes too long time to process getDomains() #7319

Closed
alexey-tikhonov opened this issue Apr 26, 2024 · 1 comment
Closed

PAC and PAM responders can crash if backend takes too long time to process getDomains() #7319

alexey-tikhonov opened this issue Apr 26, 2024 · 1 comment
Assignees
@alexey-tikhonov
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@alexey-tikhonov
Copy link
Member

sssd/src/responder/pac/pacsrv_cmd.c

Line 149 in 54179a0

req = sss_dp_get_domains_send(cctx->rctx, cctx->rctx, true,

-- request is being created on a long term responder context, but a callback for this request tries to access memory that is allocated on a short term client context. So if client disconnects before request is completed, then callback dereferences already freed memory.

https://issues.redhat.com/browse/RHEL-30142
@alexey-tikhonov alexey-tikhonov self-assigned this Apr 26, 2024
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Apr 26, 2024
@alexey-tikhonov
RESPONDER: user proper context for getDomains()
106c641 
Request was created on a long term responder context, but a callback
for this request tries to access memory that is allocated on a short
term client context. So if client disconnects before request is
completed, then callback dereferences already freed memory.

Resolves: SSSD#7319
@alexey-tikhonov alexey-tikhonov mentioned this issue Apr 26, 2024
Closed
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue May 2, 2024
@alexey-tikhonov
RESPONDER: use proper context for getDomains()
237a389 
Request was created on a long term responder context, but a callback
for this request tries to access memory that is allocated on a short
term client context. So if client disconnects before request is
completed, then callback dereferences already freed memory.

Resolves: SSSD#7319
alexey-tikhonov added a commit that referenced this issue May 2, 2024
@alexey-tikhonov
RESPONDER: use proper context for getDomains()
b0fda92 
Request was created on a long term responder context, but a callback
for this request tries to access memory that is allocated on a short
term client context. So if client disconnects before request is
completed, then callback dereferences already freed memory.

Resolves: #7319

Reviewed-by: Alejandro López <[email protected]>
Reviewed-by: Pavel Březina <[email protected]>
(cherry picked from commit dc637c9)
@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7320

  • master
    • dc637c9 - RESPONDER: use proper context for getDomains()
  • sssd-2-9
    • b0fda92 - RESPONDER: use proper context for getDomains()

@alexey-tikhonov alexey-tikhonov added the Closed: Fixed Issue was closed as fixed. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RESPONDER: use proper context for getDomains() alexey-tikhonov/sssd
1 participant
@alexey-tikhonov