tests: test case audit and house keeping #7160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
commented
Feb 1, 2024
•
danlavu
commented
- standardized all system test case names in the new framework
- test_ldap.py: moved tests from test_offline.py, and test_rootdse.py because they have one topology which only ldap. renamed test_rootdse.py test cases names
- test_authentication.py: updated non descripted docstrings.
- test_identity.py: moved tests from test_autoprivategroup.py, because it perfroms an identity lookup and is one test case.
- test_autofs.py: removed ldap from autofs requirement, because test cases are now generic.
- test_proxy.py: updated test case name to reflect what is being tested -- test case should be updated
- test_memory_cache.py: renamed test cases to make it more readable
- test_sssctl.py merged with test_sssctl_analyze.py
- test_default_debug_level.py renamed to logging.py
danlavu
force-pushed
the
audit
branch
4 times, most recently
from
ff42452 to
3f3fa58
Compare
danlavu
force-pushed
the
audit
branch
2 times, most recently
from
d73b1a5 to
6a25585
Compare
danlavu
requested review from
ikerexxe,
spoore1,
shridhargadekar,
pbrezina,
madhuriupadhye,
jakub-vavra-cz,
aborah-sudo and
patriki01
|
Added the QE team to review it, it's a big change from how we used to do things. |
danlavu
force-pushed
the
audit
branch
2 times, most recently
from
58a1968 to
eaf830c
Compare
spoore1
requested changes
Feb 13, 2024
danlavu
removed request for
aborah-sudo,
patriki01,
ikerexxe,
shridhargadekar,
madhuriupadhye and
jakub-vavra-cz
- standardized all system test case names in the new framework - test_ldap.py: moved tests from test_offline.py, and test_rootdse.py because they have one topology which only ldap. renamed test_rootdse.py test cases names - test_authentication.py: updated non descripted docstrings. - test_identity.py: moved tests from test_autoprivategroup.py, because it perfroms an identity lookup and is one test case. - test_autofs.py: removed ldap from autofs requirement, because test cases are now generic. - test_proxy.py: updated test case name to reflect what is being tested -- test case should be updated - test_memory_cache.py: renamed test cases to make it more readable - test_sssctl.py merged with test_sssctl_analyze.py - test_default_debug_level.py renamed to logging.py
pbrezina
added
Ready to push
|
@danlavu There was conflict on sssd-2-9. Can you please open standalone PR for that branch? |
|
@pbrezina ack |
This patch somehow / for some reason re-introduces tests that use '--genconf-...' options that are gone, so tests are red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.